On Fri, 14 Feb 2025 17:22:03 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - typo >> - update copyright headers > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/HeaderButtonOverlay.java > line 678: > >> 676: orderedButtons.add(this); >> 677: buttonOrder.set(order); >> 678: glyph.getStyleClass().setAll("glyph"); > > "glyph": though apt, the name might be somewhat confusing. maybe "icon"? I considered "icon", but still think that "glyph" captures the meaning a tiny bit better. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r2009054216