Resizing stage while it is maximized breaks scene size on Linux

2025-03-16 Thread Christopher Schnick
Hello, we encountered an issue on Linux where resizing the stage while it is maximized breaks the size of the scene. You can see a video of this at https://github.com/xpipe-io/xpipe/issues/485 . The root cause is that the stage size is modified. When doing this, it temporarily or permanently

Re: RFR: 8335547: Support multi-line prompt text for TextArea

2025-03-16 Thread Michael Strauß
On Wed, 19 Feb 2025 16:50:02 GMT, Ziad El Midaoui wrote: > Added multi line prompt support for TextArea this will provide the ability to > have multiple lines in textArea as expected, > Also fixed tests to meet the new changes What happens if the text contains line breaks other than `\n`, such

Re: RFR: 8335547: Support multi-line prompt text for TextArea

2025-03-16 Thread Michael Strauß
On Thu, 13 Mar 2025 17:36:35 GMT, Andy Goryachev wrote: >> Added multi line prompt support for TextArea this will provide the ability >> to have multiple lines in textArea as expected, >> Also fixed tests to meet the new changes > > modules/javafx.controls/src/main/java/javafx/scene/control/skin

Re: RFR: 8350917: Allow parent nodes to provide CSS styleable properties for child nodes

2025-03-16 Thread Michael Strauß
On Mon, 17 Feb 2025 01:15:37 GMT, John Hendrikx wrote: > 8350917: Allow parent nodes to provide CSS styleable properties for child > nodes modules/javafx.graphics/src/main/java/javafx/css/Styleable.java line 101: > 99: * only for its direct children! > 100: * > 101: * @return an

Re: RFR: 8350917: Allow parent nodes to provide CSS styleable properties for child nodes

2025-03-16 Thread John Hendrikx
On Sun, 16 Mar 2025 18:36:05 GMT, Michael Strauß wrote: >> 8350917: Allow parent nodes to provide CSS styleable properties for child >> nodes > > modules/javafx.graphics/src/main/java/javafx/css/Styleable.java line 101: > >> 99: * only for its direct children! >> 100: * >> 101: *

Re: RFR: 8350917: Allow parent nodes to provide CSS styleable properties for child nodes

2025-03-16 Thread John Hendrikx
On Sun, 16 Mar 2025 17:08:31 GMT, Michael Strauß wrote: >> 8350917: Allow parent nodes to provide CSS styleable properties for child >> nodes > > modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java line > 465: > >> 463: } >> 464: >> 465: private record StylingContex

Re: RFR: 8350917: Allow parent nodes to provide CSS styleable properties for child nodes

2025-03-16 Thread John Hendrikx
On Sun, 16 Mar 2025 18:53:41 GMT, Michael Strauß wrote: >> 8350917: Allow parent nodes to provide CSS styleable properties for child >> nodes > > modules/javafx.graphics/src/main/java/javafx/scene/layout/Pane.java line 140: > >> 138: } >> 139: >> 140: String propertyName = name

Re: RFR: 8350917: Allow parent nodes to provide CSS styleable properties for child nodes

2025-03-16 Thread John Hendrikx
On Sun, 16 Mar 2025 19:03:32 GMT, Michael Strauß wrote: >> 8350917: Allow parent nodes to provide CSS styleable properties for child >> nodes > > modules/javafx.graphics/src/main/java/javafx/scene/layout/Pane.java line 234: > >> 232: } >> 233: >> 234: if (value != null)

Re: RFR: 8350917: Allow parent nodes to provide CSS styleable properties for child nodes

2025-03-16 Thread Michael Strauß
On Mon, 17 Feb 2025 01:15:37 GMT, John Hendrikx wrote: > 8350917: Allow parent nodes to provide CSS styleable properties for child > nodes Your approach for this enhancement looks good. Do you plan to add styleable properties for the other layout containers too? - PR Comment: htt

RFR: 8351264: Some images don't load with WebKit 620.1

2025-03-16 Thread Jay Bhaskar
Issue: Some images don't load with WebKit 620.1 WebKit Image Decoding Failure Due to Unintended WebP Format Delivery WebKit encounters image decoding failures when certain servers respond with WebP images instead of the intended JPEG or PNG format. This issue arises due to WebKit's Accept header