On Sun, 16 Mar 2025 17:08:31 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> 8350917: Allow parent nodes to provide CSS styleable properties for child
>> nodes
>
> modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java line
> 465:
>
>> 463: }
>> 464:
>> 465: private record StylingContext(Node node, CalculatedValue font,
>> StyleMap styleMap, Set<PseudoClass> pseudoClasses) {}
>
> It might not be a good trade-off to create lots of transient objects on a hot
> path just to save a few arguments in the calling convention. This would be a
> nice improvement once we have value types in Java.
I checked this before hand, there is quite a bit more going on in creating the
cache keys (see `getTransitionStates`), and I think this extra object will
therefore be lost in the noise.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1714#discussion_r1997717173
