On Tue, 11 Mar 2025 02:48:50 GMT, Nir Lisker wrote:
> If we can know that the values are going to diverge then logging an error
> instead of throwing it is fine. However, if they are trying to find a common
> divisor (as in John's example above), it could take many callbacks for the
> final va
> This provides and uses a new implementation of `ExpressionHelper`, called
> `ListenerManager` with improved semantics.
>
> See also #837 for a previous attempt which instead of triggering nested
> emissions immediately (like this PR and `ExpressionHelper`) would wait until
> the current emiss
> Summary
> ---
>
> Adds a thread check to a number of `Platform` methods:
>
> accessibilityActiveProperty()
> getPreferences()
> isAccessibilityActive()
>
> These methods will throw an `IllegalStateException` if called on a thread
> other than the JavaFX Application Thread.
>
> Problem
>
On Wed, 19 Feb 2025 20:39:19 GMT, Andy Goryachev wrote:
> - enforced fx application thread
> - clarify doc where an `IllegalStateException` can get thrown, such as hide()
> and show()
> - clarified `ComboBoxBase::show`
> - added a headful test `TestThreadingRestrictions`
This pull request has n
On Mon, 10 Mar 2025 08:42:07 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/com/sun/javafx/binding/OldValueCachingListenerManager.java
>> line 53:
>>
>>> 51: * within listener list. If possible use {@link ListenerManager}, as it
>>> has less
>>> 52: * storage requirements and
On Mon, 10 Mar 2025 07:37:27 GMT, John Hendrikx wrote:
> > First part of the review.
> > There are several class (and their methods) that are `public`, but are only
> > used in their package and can just have package-access:
> > `OldValueCachingListenerList` `ListenerManagerBase` `ListenerListB
> This provides and uses a new implementation of `ExpressionHelper`, called
> `ListenerManager` with improved semantics.
>
> See also #837 for a previous attempt which instead of triggering nested
> emissions immediately (like this PR and `ExpressionHelper`) would wait until
> the current emiss
On Sun, 9 Mar 2025 22:36:42 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix non-convergence logic one more time...
>
> modules/javafx.base/src/main/java/com/sun/javafx/binding/OldValueCachingLi
On Mon, 10 Mar 2025 02:07:04 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix non-convergence logic one more time...
>
> modules/javafx.base/src/main/java/com/sun/javafx/binding/OldValueCachingL
On Mon, 10 Mar 2025 08:48:53 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> See also #837 for a previous attempt which instead of triggering nested
>> emissions immediately (like this PR
On Mon, 10 Mar 2025 02:06:11 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix non-convergence logic one more time...
>
> modules/javafx.base/src/main/java/com/sun/javafx/binding/ListenerManager.
On Mon, 10 Mar 2025 09:27:29 GMT, Michael Strauß wrote:
>> John Hendrikx has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Small fixes from review comments
>> - Use switch expression where reasonable
>> - Update docs regarding NullPo
On Mon, 10 Mar 2025 22:35:36 GMT, Kevin Rushforth wrote:
> Bump version number to 24.0.2.
>
> I plan to integrate this some time tomorrow morning (Pacific).
Reviewer: @johanvos
Since this is not a backport, it needs both a Review and a Maintainer approval.
-
PR Comment: https://g
Bump version number to 24.0.2.
I plan to integrate this some time tomorrow morning (Pacific).
-
Commit messages:
- 8351602: Change JavaFX release version to 24.0.2 in jfx24u
Changes: https://git.openjdk.org/jfx24u/pull/12/files
Webrev: https://webrevs.openjdk.org/?repo=jfx24u&pr=
On Mon, 10 Mar 2025 17:04:22 GMT, Michael Strauß wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 44 commits:
>>
>> - review comments
>> - Merge remote-tracking branch 'origin/master' into ag.text.layout.
On Fri, 7 Mar 2025 17:56:42 GMT, Andy Goryachev wrote:
>> - enforced fx application thread
>> - clarify doc where an `IllegalStateException` can get thrown, such as
>> hide() and show()
>> - clarified `ComboBoxBase::show`
>> - added a headful test `TestThreadingRestrictions`
>
> Andy Goryachev h
On Mon, 10 Mar 2025 10:41:25 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/com/sun/javafx/binding/ListenerList.java
>> line 174:
>>
>>> 172: */
>>> 173:
>>> 174: throw new StackOverflowError("non-converging value
>>> detected in value modifyin
17 matches
Mail list logo
