On Wed, 2 Aug 2023 09:47:25 GMT, Guillaume Tâche wrote:
>> This fixes ResourceBundle loading by calling
>> `ResourceBundle.getBundle(value, Locale.getDefault())` when the loader
>> resources are null or their classloader is null.
>> Apparently the original author of the bug report said they
On Thu, 3 Aug 2023 04:06:04 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasant
On Wed, 2 Aug 2023 22:21:20 GMT, Marius Hanl wrote:
> An IOOBE was thrown when scrolling up via the trough (->
> `VirtualScrollBar#adjustValue`).
> This happened only when it has bigger cells than the viewport.
> If the the uppermost cell with the index 0 is only visible (although not
> comple
On Tue, 1 Aug 2023 11:29:55 GMT, Jose Pereda wrote:
>> This is a different type of a problem, that imho should be addressed as
>> well, but in a separate issue which also contains a test strategy. This is
>> something that requires a hash-based solution, but it is something that
>> needs to be
On Tue, 1 Aug 2023 11:25:49 GMT, Jose Pereda wrote:
>> Probably something to evaluate, but in a separate ticket
>
> I agree, this should probably be considered as well, as part of a separate
> ticket.
>
> Note that, when the file already exists in the cache, the initial InputStream
> object i
On Thu, 3 Aug 2023 11:41:30 GMT, Kevin Rushforth wrote:
>> An IOOBE was thrown when scrolling up via the trough (->
>> `VirtualScrollBar#adjustValue`).
>> This happened only when it has bigger cells than the viewport.
>> If the the uppermost cell with the index 0 is only visible (although not
On Thu, 3 Aug 2023 11:48:49 GMT, Kevin Rushforth wrote:
>> Agree to do it separately, but in any case, if there was already a file at
>> the cache directory, its checksum is verified, and in case it is not the
>> same, the file is removed from the cache, before it is copied again.
>> Does this
`setHeight()` / `setWidth()` were ignored if called after `sizeToScene()` and
before `show()`.
Now the `sizeToScene` flag is unset in these methods to ensure the right values
are set when the window is shown.
-
Commit messages:
- 8310885: Width/height of window is not set aft
> An IOOBE was thrown when scrolling up via the trough (->
> `VirtualScrollBar#adjustValue`).
> This happened only when it has bigger cells than the viewport.
> If the the uppermost cell with the index 0 is only visible (although not
> completely scrolled to the top) and then an attempt is made
On Thu, 3 Aug 2023 14:57:50 GMT, Guillaume Tâche wrote:
> `setHeight()` / `setWidth()` were ignored if called after `sizeToScene()` and
> before `show()`.
> Now the `sizeToScene` flag is unset in these methods to ensure the right
> values are set when the window is shown.
The fix looks r
On Fri, 9 Jun 2023 12:45:02 GMT, John Hendrikx wrote:
>> This fix introduces immutable sets of `PseudoClass` almost everywhere, as
>> they are rarely modified. These are re-used by caching them in a new class
>> `ImmutablePseudoClassSetsCache`.
>>
>> In order to make this work, `BitSet` had t
On Thu, 3 Aug 2023 15:15:57 GMT, Marius Hanl wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' of https://git.openjdk.org/jfx into
>>feature/immutable-pseudoclas
On Fri, 9 Jun 2023 12:45:02 GMT, John Hendrikx wrote:
>> This fix introduces immutable sets of `PseudoClass` almost everywhere, as
>> they are rarely modified. These are re-used by caching them in a new class
>> `ImmutablePseudoClassSetsCache`.
>>
>> In order to make this work, `BitSet` had t
On Thu, 3 Aug 2023 15:18:51 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line
>> 263:
>>
>>> 261:
>>> 262:
>>> 263: /** {@inheritDoc} */
>>
>> Isn't this still needed?
>
> There is an `@Override` annotation, javadoc will do the right t
On Thu, 3 Aug 2023 04:06:04 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasant
Cherry-picked commits from webkitgtk-2.40.5.
Verified build on windows, mac and linux. Sanity testing looks fine. No issues
seen
-
Commit messages:
- white space correction
- cherry-pick webkit-2.40.5
Changes: https://git.openjdk.org/jfx/pull/1196/files
Webrev: https://webrevs.op
On Thu, 3 Aug 2023 17:54:48 GMT, Hima Bindu Meda wrote:
> Cherry-picked commits from webkitgtk-2.40.5.
> Verified build on windows, mac and linux. Sanity testing looks fine. No
> issues seen
I changed the JBS title to match the pattern that we use for cherry-picking
stabilization fixes.
-
On Thu, 22 Jun 2023 11:45:30 GMT, Thiago Milczarek Sayao
wrote:
>> This PR adds missing key mappings for dead keys and fixes "Alt Gr" for some
>> systems.
>
> Thiago Milczarek Sayao has updated the pull request with a new target base
> due to a merge or a rebase. The incremental webrev exclude
On Wed, 5 Jul 2023 19:30:21 GMT, Andy Goryachev wrote:
>> Modified the resize algorithm to work well with fractional scale, thanks for
>> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>>
>> It is important to note that even though the constraints are given by the
>> user i
On Wed, 2 Aug 2023 16:36:47 GMT, Marius Hanl wrote:
> When a table has padding or the `layoutChildren` method inside the table skin
> is overridden (and x/y are modified), the drag drag header, column overlay
> and column line are not correctly aligned.
>
> The reason is that the positions wer
On Thu, 3 Aug 2023 15:22:39 GMT, Marius Hanl wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' of https://git.openjdk.org/jfx into
>>feature/immutable-pseudoclas
On Thu, 3 Aug 2023 15:24:40 GMT, Marius Hanl wrote:
>> There is an `@Override` annotation, javadoc will do the right thing.
>
> So it is only needed when we want to add something to the javadoc coming from
> the superclass?
Yes, that's correct. `@inheritDoc` is only needed when you want to add
On Thu, 3 Aug 2023 04:06:04 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasant
On Thu, 3 Aug 2023 18:04:23 GMT, Andy Goryachev wrote:
> The good:
>
> * image on both monitors (macOS) appear with no gaps
>
> * text on both monitors looks good, anti-aliasing works as expected
>
>
> The bad:
>
> * both windows (using EmbeddedFrameBug class listed earlier) show
> When the JavaFX scene is set before it is really shown, then the scale
> factors are not properly propagated to the EmbeddedWindow, resulting in
> showing wrong scales.
> Fix is made to update scales to EmbeddedWindow
Prasanta Sadhukhan has updated the pull request incrementally with one
addi
On Thu, 3 Aug 2023 17:55:14 GMT, Andy Goryachev wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Call updateSceneState with lock and in FX thread
>
> modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPa
26 matches
Mail list logo
