On Thu, 3 Aug 2023 17:55:14 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Call updateSceneState with lock and in FX thread > > modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java line 826: > >> 824: } >> 825: double newScaleFactorX = >> config.getDefaultTransform().getScaleX(); >> 826: double newScaleFactorY = >> config.getDefaultTransform().getScaleY(); > > minor suggestion: create a method get[Current]Transform() to avoid code > duplication (here and line 621) done ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1171#discussion_r1284026118
