On Mon, 17 Jan 2022 20:25:08 GMT, Martin Fox wrote:
> The Robot implementation on Linux did not consult the current layout when
> mapping from a KeyCode to a hardware code. Internally it retrieved results
> for all the layouts but just picked the first one it saw leading to random
> effects. T
On Fri, 31 Mar 2023 18:07:08 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line
>> 584:
>>
>>> 582: * @param obj the object to cast, cannot be {@code null}
>>> 583: * @return a type T, or {@code null} if the argument was not of
>>>
On Fri, 31 Mar 2023 07:57:11 GMT, Hima Bindu Meda wrote:
> In Jenkins Build, the intermediate failure on windows is observed due to
> crash in mspdbserv.exe, which generates Program database (.pdb) files.
> Disabled the pdb file generation in order to resolve the build failure.
> Sanity testing
On Sat, 1 Apr 2023 18:14:11 GMT, Michael Strauß wrote:
>> `Observable{List/Set/Map}Wrapper.retainAll/removeAll` can be optimized for
>> some edge cases.
>>
>> 1. `removeAll(c)`:
>> This is a no-op if 'c' is empty.
>> For `ObservableListWrapper`, returning early skips an object allocation. For
On Mon, 17 Jan 2022 20:25:08 GMT, Martin Fox wrote:
> The Robot implementation on Linux did not consult the current layout when
> mapping from a KeyCode to a hardware code. Internally it retrieved results
> for all the layouts but just picked the first one it saw leading to random
> effects. T
On Tue, 21 Mar 2023 22:49:34 GMT, Martin Fox wrote:
>> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as
>> expected by more accurately mapping from a Mac key code to a Java key code
>> based on the user’s active keyboard layout (the existing code assumes a US
>> QWERTY l
On Fri, 3 Mar 2023 01:13:49 GMT, Thiago Milczarek Sayao
wrote:
>> This PR does:
>>
>> - Remove specific Idea files and let it be imported from gradle;
>> - Adds checkstyle (to use with checkstyle plugin - it will let you know
>> style mistakes);
>> - Configures auto-format to sun style (with t
On Sat, 1 Apr 2023 03:32:43 GMT, Michael Strauß wrote:
>> `Observable{List/Set/Map}Wrapper.retainAll/removeAll` can be optimized for
>> some edge cases.
>>
>> 1. `removeAll(c)`:
>> This is a no-op if 'c' is empty.
>> For `ObservableListWrapper`, returning early skips an object allocation. For
On Fri, 13 Jan 2023 23:04:58 GMT, John Neffenger wrote:
>> This pull request allows for reproducible builds of JavaFX on Linux, macOS,
>> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For
>> example, the following commands create a reproducible build:
>>
>>
>> $ export
On Mon, 3 Apr 2023 06:22:39 GMT, Michael Strauß wrote:
>> John Hendrikx has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Base BitSet on AbstractSet to inherit correct equals/hashCode/toArray
>>
>>- Removed faulty toArray imple
Or, rather than removing the check entirely, make it a warning.
-- Kevin
On 3/31/2023 9:03 AM, John Neffenger wrote:
On 3/30/23 11:17 AM, Glavo wrote:
I compiled OpenJFX for RISC-V and MIPS64el platforms with reference
to your patch, thereby porting our JavaFX applications to these
platforms
On Wed, 11 Jan 2023 23:11:59 GMT, John Neffenger wrote:
>> I'll need a bit more time to run CI test builds again. I'm thinking it might
>> be better to get this in early in JavaFX 21 rather than late in JavaFX 20
>> anyway.
>
>> I'll need a bit more time to run CI test builds again. I'm thinkin
On Sun, 2 Apr 2023 23:49:55 GMT, Michael Strauß wrote:
>> I'm a bit unsure why that would be an improvement. Passing `null` to a
>> function that doesn't expect it should IMHO never just return `null` but
>> should instead be considered a programming error and result in a stack
>> trace. Pass
On Sat, 18 Feb 2023 23:35:40 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix no change detection
>>
>> Old text was uppercased while new text is always lowercase.
>
> With this test
>
>
> This cleans size and positioning code, reducing special cases, code
> complexity and size.
>
> Changes:
>
> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
> sizes. It does not assume any size because it varies - it does cache because
> it's unlikely to vary on t
On Wed, 1 Mar 2023 22:40:53 GMT, Thiago Milczarek Sayao
wrote:
>> Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore
>> this scroll event type, deltas are sent to java with the value equal to zero.
>>
>> Here's whats happening:
>>
>> We include all event masks, so when u
On Thu, 26 Jan 2023 08:54:44 GMT, Florian Kirmaier
wrote:
>> Making the initial listener of the ListProperty weak fixes the problem.
>> The same is fixed for Set and Map.
>> Due to a smart implementation, this is done without any performance drawback.
>> (The trick is to have an object, which is
On Mon, 3 Apr 2023 06:29:29 GMT, Michael Strauß wrote:
>> BitSet uses the SetListenerHelper abstraction to prevent allocating the
>> listener arrays.
>>
>> When removing listeners, the newly returned listener helper (which may be
>> different from the one called) is not reassigned. This effect
On Fri, 13 Jan 2023 09:18:56 GMT, Florian Kirmaier
wrote:
>> This PR fixes the leak in the mac system menu bar.
>>
>> Inside the native code, NewGlobalRef is called for the callable.
>> Which makes it into a "GC-Root" until DeleteGlobalRef is called.
>>
>> The DeleteGlobalRef is never called f
On Mon, 18 Jul 2022 12:18:49 GMT, Florian Kirmaier
wrote:
>> When using Swing it's possible to generate a Deadlock.
>> It's related to the nested eventloop started in enterFullScreenExitingLoop
>> - and the RenderLock aquired when using setView in Scene.
>> Sample Programm and Threaddump are
On Sat, 1 Apr 2023 10:02:26 GMT, Marius Hanl wrote:
>> The determined `prefWidth` of a `TableCell` could be `0.0` when a
>> `fixedCellSize` is set.
>> This happened because the `TableCell` may not have a skin since it was never
>> added to the scene graph yet.
>>
>> The fix is to make sure we
> In Jenkins Build, the intermediate failure on windows is observed due to
> crash in mspdbserv.exe, which generates Program database (.pdb) files.
> Disabled the pdb file generation in order to resolve the build failure.
> Sanity testing looks fine. Verified build on windows, mac and linux.
Hima
On Mon, 3 Apr 2023 08:00:50 GMT, Jose Pereda wrote:
>> Marius Hanl has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - JDK-8305248: Added the tests also for TreeTableRow
>> - JDK-8305248: Improve comments
>
> modules/javafx.controls/src/m
On Mon, 3 Apr 2023 08:10:04 GMT, Jose Pereda wrote:
>> Marius Hanl has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - JDK-8305248: Added the tests also for TreeTableRow
>> - JDK-8305248: Improve comments
>
> modules/javafx.controls/src/t
On Mon, 3 Apr 2023 09:31:15 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableRowSkinBase.java
>> line 356:
>>
>>> 354: getChildren().add(tableCell);
>>> 355: }
>>> 356: // Note: prefWidth() has to
On Sat, 1 Apr 2023 10:02:26 GMT, Marius Hanl wrote:
>> The determined `prefWidth` of a `TableCell` could be `0.0` when a
>> `fixedCellSize` is set.
>> This happened because the `TableCell` may not have a skin since it was never
>> added to the scene graph yet.
>>
>> The fix is to make sure we
I have submitted a Draft PR here:
https://github.com/openjdk/jfx/pull/1080
It's not 100% right yet, I need some feedback to work on it.
Em seg., 20 de mar. de 2023 às 09:50, Thiago Milczarek Sayão <
thiago.sa...@gmail.com> escreveu:
> Hi,
>
> I'm working on IME (Input Method Editor) on Linux a
On Sun, 2 Apr 2023 09:29:40 GMT, Johan Vos wrote:
> do you have insight in why removing the debug flag "fixes" the problem? Are
> we sure that there is not something wrong below the surface that becomes
> visible in case
The problem is triggered by the generation of the PDB files. PDB files ar
On Mon, 3 Apr 2023 09:21:08 GMT, Hima Bindu Meda wrote:
>> In Jenkins Build, the intermediate failure on windows is observed due to
>> crash in mspdbserv.exe, which generates Program database (.pdb) files.
>> Disabled the pdb file generation in order to resolve the build failure.
>> Sanity testi
On Sun, 2 Apr 2023 23:45:52 GMT, Michael Strauß wrote:
>> modules/javafx.base/src/test/java/test/com/sun/javafx/collections/ObservableListWrapperTest.java
>> line 41:
>>
>>> 39:
>>> 40: @Nested
>>> 41: class RemoveAllTest {
>>
>> Empty line after class declaration.
>>
>> Same for oth
> This pull request allows for reproducible builds of JavaFX on Linux, macOS,
> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For
> example, the following commands create a reproducible build:
>
>
> $ export SOURCE_DATE_EPOCH=$(git log -1 --pretty=%ct)
> $ bash gradlew s
On Sun, 2 Apr 2023 20:49:38 GMT, Thiago Milczarek Sayao
wrote:
>> This cleans size and positioning code, reducing special cases, code
>> complexity and size.
>>
>> Changes:
>>
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
>> sizes. It does not assume any siz
On Sat, 1 Apr 2023 10:02:26 GMT, Marius Hanl wrote:
>> The determined `prefWidth` of a `TableCell` could be `0.0` when a
>> `fixedCellSize` is set.
>> This happened because the `TableCell` may not have a skin since it was never
>> added to the scene graph yet.
>>
>> The fix is to make sure we
On Tue, 21 Mar 2023 22:49:34 GMT, Martin Fox wrote:
>> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as
>> expected by more accurately mapping from a Mac key code to a Java key code
>> based on the user’s active keyboard layout (the existing code assumes a US
>> QWERTY l
My two cents: I think the functionality of debouncing should better be solved
by a separate facility, rather than added to observables. An example would be
a use case when multiple observables trigger an expensive or delayed
computation or a UI update.
Something along the lines of
https://gith
On Thu, 30 Mar 2023 19:58:31 GMT, Marius Hanl wrote:
> The determined `prefWidth` of a `TableCell` could be `0.0` when a
> `fixedCellSize` is set.
> This happened because the `TableCell` may not have a skin since it was never
> added to the scene graph yet.
>
> The fix is to make sure we get t
On Mon, 3 Apr 2023 09:21:08 GMT, Hima Bindu Meda wrote:
>> In Jenkins Build, the intermediate failure on windows is observed due to
>> crash in mspdbserv.exe, which generates Program database (.pdb) files.
>> Disabled the pdb file generation in order to resolve the build failure.
>> Sanity testi
On Mon, 3 Apr 2023 13:25:34 GMT, Kevin Rushforth wrote:
>> Hima Bindu Meda has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove white space
>
> modules/javafx.web/src/main/native/Source/cmake/OptionsMSVC.cmake line 114:
>
>> 112: if (
> In Jenkins Build, the intermediate failure on windows is observed due to
> crash in mspdbserv.exe, which generates Program database (.pdb) files.
> Disabled the pdb file generation in order to resolve the build failure.
> Sanity testing looks fine. Verified build on windows, mac and linux.
Hima
Hi Andy,
Those examples seem to be just timers, it would be hard to construct the
primitives like throttle and debounce with these, as they don't take
into account when the value last changed, or whether or not is important
that the value changed again (reset timer or not). These timers would
Right. I am not saying we should take these classes as is.
In my opinion, this functionality might be better supported by a separate
facility(ies). Specifically, to handle the case of multiple observables.
I also think the APIs are large and complicated enough already, it might be
better to a
On Mon, 3 Apr 2023 18:50:57 GMT, Hima Bindu Meda wrote:
>> In Jenkins Build, the intermediate failure on windows is observed due to
>> crash in mspdbserv.exe, which generates Program database (.pdb) files.
>> Disabled the pdb file generation in order to resolve the build failure.
>> Sanity testi
On Fri, 3 Mar 2023 01:13:49 GMT, Thiago Milczarek Sayao
wrote:
>> This PR does:
>>
>> - Remove specific Idea files and let it be imported from gradle;
>> - Adds checkstyle (to use with checkstyle plugin - it will let you know
>> style mistakes);
>> - Configures auto-format to sun style (with t
Hi Andy,
On 03/04/2023 21:14, Andy Goryachev wrote:
Right. I am not saying we should take these classes as is.
In my opinion, this functionality might be better supported by a
separate facility(ies). Specifically, to handle the case of multiple
observables.
Can you elaborate on what cases
On Tue, 28 Mar 2023 15:09:29 GMT, Kevin Rushforth wrote:
> A malformed unicode string containing only half of a surrogate pair (either a
> high or low surrogate without the other half) will cause a native exception
> in the macOS `NSPasteboardItem setString:forType:` method. This uncaught
> ex
This PR addresses some font problems on macOS.
(1) Garbled Arabic with the System font
(2) Non-ideal fallback fonts for all fonts
(3) No bold for System font.
In particular the standard System Font was garbling Arabic text - random glyphs
from another font.
The root of this issue is that several
On Fri, 24 Mar 2023 21:37:16 GMT, Phil Race wrote:
> This PR addresses some font problems on macOS.
> (1) Garbled Arabic with the System font
> (2) Non-ideal fallback fonts for all fonts
> (3) No bold for System font.
>
> In particular the standard System Font was garbling Arabic text - random
On Fri, 24 Mar 2023 21:37:16 GMT, Phil Race wrote:
> This PR addresses some font problems on macOS.
> (1) Garbled Arabic with the System font
> (2) Non-ideal fallback fonts for all fonts
> (3) No bold for System font.
>
> In particular the standard System Font was garbling Arabic text - random
On Mon, 27 Mar 2023 16:56:16 GMT, Andy Goryachev wrote:
> * italic is rendered as bold
That was in the draft PR and I said a known issue to ignore. It is already
resolved.
The missing scripts are because macOS isn't enumerating supplemental fonts that
support them as fallbacks. That's a topic
I have some observations about the method `fireValueChangedEvent` that
most PropertyBase classes provide.
They seem to have several design problems:
1) It's specified that it is called internally when `set` is called
(dangerous, as it can be overriden and not do anything breaking the
contract
On Mon, 3 Apr 2023 16:19:47 GMT, Jose Pereda wrote:
>> Martin Fox has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added manual cross-platform keyboard handling test
>
> tests/manual/events/KeyboardTest.java line 79:
>
>> 77: */
>> 78:
On Mon, 3 Apr 2023 22:39:24 GMT, Phil Race wrote:
> You mention "Thai" amongst them .. but I do see Thai rendered ..
Thai is not rendered for me, was Ventura 13.1, now Ventura 13.3 on Mac M1,
(left - ventura 13.1 with the earlier commit, right - unpatched master)
