On Tue, 21 Mar 2023 22:49:34 GMT, Martin Fox <d...@openjdk.org> wrote:
>> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as >> expected by more accurately mapping from a Mac key code to a Java key code >> based on the user’s active keyboard layout (the existing code assumes a US >> QWERTY layout). The new code first identifies a set of Mac keys which can >> produce different characters based on the user’s keyboard layout. A Mac key >> code outside that area is processed exactly as before. For a key inside the >> layout-sensitive area the code calls UCKeyTranslate to translate the key to >> an unshifted ASCII character based on the active keyboard and uses that to >> determine the Java key code. >> >> When performing the reverse mapping for the Robot the code first uses the >> old QWERTY mapping to find a candidate key. If it lies in the >> layout-sensitive area the code then scans the entire area calling >> UCKeyTranslate until it finds a match. If the key lies outside the >> layout-sensitive area it’s processed exactly as before. >> >> There are multiple duplicates of these bugs logged against Mac applications >> built with JavaFX. >> >> https://bugs.openjdk.java.net/browse/JDK-8090257 Mac: Inconsistent KeyEvents >> with alternative keyboard layouts >> https://bugs.openjdk.java.net/browse/JDK-8088120 [Accelerator, Mac] CMD + Z >> accelerator is not working with French keyboard >> https://bugs.openjdk.java.net/browse/JDK-8087915 Mac: accelerator doesn't >> take into account azerty keyboard layout >> https://bugs.openjdk.java.net/browse/JDK-8150709 Mac OSX and German Keyboard >> Layout (Y/Z) > > Martin Fox has updated the pull request incrementally with one additional > commit since the last revision: > > Added manual cross-platform keyboard handling test tests/manual/events/KeyboardTest.java line 79: > 77: */ > 78: > 79: public class KeyboardTest extends Application { Could you clarify how to run the test and what one should expect? In my case, I'm running from Mac, with a Spanish physical keyboard, but changed to German keyboard from Keyboard -> Input sources -> German, and whether the Keyboard viewer is visible or not, I get: [Mac] Testing 78 keys on German without combinations Failed: code Numpad 0 did not produce any events ... Failed: code Decimal did not produce any events Tested 78 keys with 76 failures Is that expected? Is that test only meant for a German keyboard? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/425#discussion_r1156181269
