RFR: JDK-8304705 Parent class contains 6 constants that should be static

2023-03-22 Thread John Hendrikx
Made 6 constants static in `Parent`. Discovered these with the Java Object Layout tool. - Commit messages: - Make constants static Changes: https://git.openjdk.org/jfx/pull/1064/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1064&range=00 Issue: https://bugs.openjdk.org

Loading of shared libraries required by JFX

2023-03-22 Thread Armin Schrenk
Hey everybody, what is the recommended way for loading shared libraries required by JFX? I have to decide between "java.library.path" and some internal path determination of jfx. My background: I'm a software developer of Cryptomator, a Java GUI app to encrypt files using JFX. We are shippin

Re: RFR: JDK-8304705 Parent class contains 6 constants that should be static

2023-03-22 Thread Kevin Rushforth
On Wed, 22 Mar 2023 10:00:04 GMT, John Hendrikx wrote: > Made 6 constants static in `Parent`. Discovered these with the Java Object > Layout tool. Looks good. This seems like an obvious oversight. - Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/10

Re: RFR: 8304323 Provide infrastructure to make it possible for properties to delay listener registration

2023-03-22 Thread Kevin Rushforth
On Sun, 5 Feb 2023 13:07:25 GMT, John Hendrikx wrote: > This PR contains changes to make it easier to implement properties which want > to conserve resources until they're observed themselves. > > `isObserved` is promoted from `ObjectBinding` to the `ObservableValue` > interface, allowing yo

Re: RFR: 8304323 Provide infrastructure to make it possible for properties to delay listener registration

2023-03-22 Thread Nir Lisker
On Wed, 22 Mar 2023 14:10:20 GMT, Kevin Rushforth wrote: > @nlisker do you also want to review this? Yes, but it will take me a bit of time to get to it. - PR Comment: https://git.openjdk.org/jfx/pull/1023#issuecomment-1479756994

Re: RFR: 8304323 Provide infrastructure to make it possible for properties to delay listener registration

2023-03-22 Thread Kevin Rushforth
On Wed, 22 Mar 2023 15:14:22 GMT, Nir Lisker wrote: > > @nlisker do you also want to review this? > > Yes, but it will take me a bit of time to get to it. Likewise. This is a pretty big change that will need careful review. - PR Comment: https://git.openjdk.org/jfx/pull/1023#issue

Integrated: JDK-8304705 Parent class contains 6 constants that should be static

2023-03-22 Thread John Hendrikx
On Wed, 22 Mar 2023 10:00:04 GMT, John Hendrikx wrote: > Made 6 constants static in `Parent`. Discovered these with the Java Object > Layout tool. This pull request has now been integrated. Changeset: 85e529de Author:John Hendrikx URL: https://git.openjdk.org/jfx/commit/85e529de73

Re: RFR: 8304323 Provide infrastructure to make it possible for properties to delay listener registration

2023-03-22 Thread John Hendrikx
On Wed, 22 Mar 2023 15:17:11 GMT, Kevin Rushforth wrote: >>> @nlisker do you also want to review this? >> >> Yes, but it will take me a bit of time to get to it. > >> > @nlisker do you also want to review this? >> >> Yes, but it will take me a bit of time to get to it. > > Likewise. This is a

Re: RFR: 8304323 Provide infrastructure to make it possible for properties to delay listener registration

2023-03-22 Thread Kevin Rushforth
On Wed, 22 Mar 2023 15:42:17 GMT, John Hendrikx wrote: > BTW, not sure why `jcheck` keeps failing on this PR, as far as I can see it > is not a lack of reviewers or an incorrect title. It doesn't keep failing. The `jcheck` check is a stale check that has been superseded by `jcheck-openjdk/jfx-

Re: Loading of shared libraries required by JFX

2023-03-22 Thread Kevin Rushforth
This seems like a bug to me. Can you provide the output of running with "java -Djavafx.verbose=true". That will show how the libraries are being loaded. Depending on what the verbose output shows, we can file a bug to investigate fixing it. As for your question about the first item in the searc

Re: RFR: 8299595: Remove terminally deprecated JavaFX GTK 2 library [v10]

2023-03-22 Thread Kevin Rushforth
On Mon, 6 Mar 2023 23:47:27 GMT, Thiago Milczarek Sayao wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Rollback + Change Warnings >> - Revert "Throw exception if unsupported or invalid version specif

Re: RFR: 8299595: Remove terminally deprecated JavaFX GTK 2 library [v10]

2023-03-22 Thread Kevin Rushforth
On Mon, 6 Mar 2023 23:47:27 GMT, Thiago Milczarek Sayao wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Rollback + Change Warnings >> - Revert "Throw exception if unsupported or invalid version specif

Re: RFR: 8299595: Remove terminally deprecated JavaFX GTK 2 library [v11]

2023-03-22 Thread Thiago Milczarek Sayao
> Simple PR to remove gtk2 library compilation and loading. Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 49 additional commits

Re: RFR: 8299595: Remove terminally deprecated JavaFX GTK 2 library [v10]

2023-03-22 Thread Thiago Milczarek Sayao
On Thu, 2 Mar 2023 17:01:02 GMT, Thiago Milczarek Sayao wrote: >> Simple PR to remove gtk2 library compilation and loading. > > Thiago Milczarek Sayao has updated the pull request incrementally with two > additional commits since the last revision: > > - Rollback + Change Warnings > - Revert

Re: RFR: 8299595: Remove terminally deprecated JavaFX GTK 2 library [v11]

2023-03-22 Thread Kevin Rushforth
On Wed, 22 Mar 2023 23:08:49 GMT, Thiago Milczarek Sayao wrote: >> Simple PR to remove gtk2 library compilation and loading. > > Thiago Milczarek Sayao has updated the pull request with a new target base > due to a merge or a rebase. The incremental webrev excludes the unrelated > changes brou