If that is in line with what most people want, I can create a PR to
add this to the CONTRIBUTING.md file.
All good from my point of view. That would be great, thank you.
-- Kevin
On 7/10/2024 12:25 AM, Johan Vos wrote:
Thanks all for commenting.
What I have read so far seems that there is
Sounds good. Maybe also add that junit 5 should be used and 4 is just
legacy.
Note that the wiki also has instructions related to tests, but I think it's
just for running them.
On Wed, Jul 10, 2024, 10:25 Johan Vos wrote:
> Thanks all for commenting.
> What I have read so far seems that there i
Thanks all for commenting.
What I have read so far seems that there is an agreement for this approach:
* don't prefix tests with `test` anymore
* use a (somehow) descriptive name
* add a comment that refers to the JBS issue that this test is dealing with
* (optional) in case the test or test scenar
Goryachev , Johan Vos <
> johan@gluonhq.com>, openjfx-dev
> *Subject: *Re: [External] : Re: consistent naming for tests
>
> Perhaps, and I guess we're lucky the classes don't fully overlap then...
> if encfs just cuts off too long names when reading/writing, then as l
>
> * in some cases, tests are always prefixed with `test` (e.g. `testFoo()`)
> * in some cases, tests have a concise but somehow meaningful name (e.g.
> `testScrollBarStaysVisible`)
Prefixing 'test' was an old convention for testing frameworks. I have been
dropping that prefix in my projects sin
I wonder what other filesystems do? I just want our code to compile in Eclipse
on Linux Mint.
-andy
From: John Hendrikx
Date: Tuesday, July 9, 2024 at 11:04
To: Andy Goryachev , Johan Vos
, openjfx-dev
Subject: Re: [External] : Re: consistent naming for tests
Perhaps, and I guess we&#x
July 9, 2024 at 10:47
*To: *Andy Goryachev , Johan Vos
, openjfx-dev
*Subject: *Re: [External] : Re: consistent naming for tests
Then I can't explain why it doesn't fail on Gradle; it must be
generating similar named classes then, but perhaps at a different
location (not on encfs) ?.
: Tuesday, July 9, 2024 at 10:47
To: Andy Goryachev , Johan Vos
, openjfx-dev
Subject: Re: [External] : Re: consistent naming for tests
Then I can't explain why it doesn't fail on Gradle; it must be generating
similar named classes then, but perhaps at a different location (no
rved.class.
-andy
*From: *John Hendrikx
*Date: *Tuesday, July 9, 2024 at 10:31
*To: *Andy Goryachev , Johan Vos
, openjfx-dev
*Subject: *Re: [External] : Re: consistent naming for tests
Perhaps it is something Eclipse does differently. Normally nested
classed are numbered ($1, $2), so perh
led$WithNotNullReturns_ObservableValue_Which$WhenObservedForInvalidations$AndWhenUnobserved.class.
-andy
From: John Hendrikx
Date: Tuesday, July 9, 2024 at 10:31
To: Andy Goryachev , Johan Vos
, openjfx-dev
Subject: Re: [External] : Re: consistent naming for tests
Perhaps it is something Eclipse d
k:
https://github.com/andy-goryachev-oracle/jfx/pull/9
-andy
*From: *John Hendrikx
*Date: *Tuesday, July 9, 2024 at 08:22
*To: *Andy Goryachev , Johan Vos
, openjfx-dev
*Subject: *[External] : Re: consistent naming for tests
On 09/07/2024 16:52, Andy Goryachev wrote:
Two test files consistentl
at 09:03
To: openjfx-dev@openjdk.org
Subject: Re: [External] : Re: consistent naming for tests
https://github.com/andy-goryachev-oracle/jfx/pull/9
Hmm. I don't really like the abbreviations. They would change something that is
self-explanatory to something completely opaque, although I se
nd thought that it might be just as
easy to fix the tests... here is how the fix might look:
https://github.com/andy-goryachev-oracle/jfx/pull/9
-andy
*From: *John Hendrikx
*Date: *Tuesday, July 9, 2024 at 08:22
*To: *Andy Goryachev , Johan Vos
, openjfx-dev
*Subject: *[External] : Re: consis
t might be just as easy to fix the tests...
here is how the fix might look:
https://github.com/andy-goryachev-oracle/jfx/pull/9
-andy
From: John Hendrikx
Date: Tuesday, July 9, 2024 at 08:22
To: Andy Goryachev , Johan Vos
, openjfx-dev
Subject: [External] : Re: consistent naming for tests
This might be a combination of Eclipse and eCryptfs. I agree that 143
chars is very short for a max length.
-- Kevin
On 7/9/2024 8:22 AM, John Hendrikx wrote:
On 09/07/2024 16:52, Andy Goryachev wrote:
Two test files consistently generate an error in Eclipse
- ObservableValueFluentBindin
On 09/07/2024 16:52, Andy Goryachev wrote:
Two test files consistently generate an error in Eclipse
- ObservableValueFluentBindingsTest
- LazyObjectBindingTest
I admit I have a weird setup (EncFS on Linux Mint running on MacBook
Pro), and it only manifests itself in Eclipse and not in the gr
I generally like descriptive names for test methods (and classes) rather
than encoding the bug ID in the name. A comment with the bug ID is very
helpful, and I would support making that a best practice. If the purpose
of a test is non-obvious, a comment explaining it is a good idea.
-- Kevin
u use @Nested, please keep the class names short.
Thank you
-andy
From: openjfx-dev on behalf of Johan Vos
Date: Tuesday, July 9, 2024 at 02:33
To: openjfx-dev
Subject: consistent naming for tests
Hi,
An interesting question from John Hendrikx
(https://github.com/openjdk/jfx/pull
On 09/07/2024 11:33, Johan Vos wrote:
Hi,
An interesting question from John Hendrikx
(https://github.com/openjdk/jfx/pull/1283/#discussion_r1637684395)
probably needs some general discussion on this list.
Afaik, we don't have guidelines for how to name tests (in
https://github.com/openjdk/j
Hi,
An interesting question from John Hendrikx (
https://github.com/openjdk/jfx/pull/1283/#discussion_r1637684395) probably
needs some general discussion on this list.
Afaik, we don't have guidelines for how to name tests (in
https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md#coding-style-
20 matches
Mail list logo
