My Eclipse never had this long filename problem, and I reviewed the fluent bindings PR when it was written so I would have seen it. You can try the most basic version of Eclipse ( https://download.eclipse.org/eclipse/downloads/) to see if it still happens if you want to dig into it.
On Tue, Jul 9, 2024 at 9:09 PM Andy Goryachev <andy.goryac...@oracle.com> wrote: > I wonder what other filesystems do? I just want our code to compile in > Eclipse on Linux Mint. > > > > -andy > > > > > > > > *From: *John Hendrikx <john.hendr...@gmail.com> > *Date: *Tuesday, July 9, 2024 at 11:04 > *To: *Andy Goryachev <andy.goryac...@oracle.com>, Johan Vos < > johan....@gluonhq.com>, openjfx-dev <openjfx-dev@openjdk.org> > *Subject: *Re: [External] : Re: consistent naming for tests > > Perhaps, and I guess we're lucky the classes don't fully overlap then... > if encfs just cuts off too long names when reading/writing, then as long as > the filename is still unique enough that is going to work. As soon as two > file names would overlap, they would overwrite each other and there's no > way that the code would still work then. > > I doubt however this is reasonable to fix in Eclipse; the filesystem is > not behaving correctly -- encfs should error out instead of silently > truncating too long names. > > --John > > On 09/07/2024 19:50, Andy Goryachev wrote: > > or gradle may not be verifying that the file is actually deleted. > > > > Eclipse allows for online replacement (? or whatever that feature is > called when it can recompile and replace classes in a running vm), so > perhaps it is more diligent when it comes to deleting. > > > > -andy > > > > *From: *John Hendrikx <john.hendr...@gmail.com> <john.hendr...@gmail.com> > *Date: *Tuesday, July 9, 2024 at 10:47 > *To: *Andy Goryachev <andy.goryac...@oracle.com> > <andy.goryac...@oracle.com>, Johan Vos <johan....@gluonhq.com> > <johan....@gluonhq.com>, openjfx-dev <openjfx-dev@openjdk.org> > <openjfx-dev@openjdk.org> > *Subject: *Re: [External] : Re: consistent naming for tests > > Then I can't explain why it doesn't fail on Gradle; it must be generating > similar named classes then, but perhaps at a different location (not on > encfs) ?. > > --John > > On 09/07/2024 19:35, Andy Goryachev wrote: > > Anonymous classes are named $1. Nested classes retain their name. > > > > From the ticket: > > > > https://bugs.openjdk.org/browse/JDK-8334497 > > > > Could not delete: > /home/ag/Projects/jfx-2/jfx/rt/modules/javafx.base/testbin/test/javafx/beans/value/ObservableValueFluentBindingsTest$When_flatMap_Called$WithNotNullReturns_ObservableValue_Which$WhenObservedForInvalidations$AndWhenUnobserved.class. > > > > -andy > > > > > > *From: *John Hendrikx <john.hendr...@gmail.com> <john.hendr...@gmail.com> > *Date: *Tuesday, July 9, 2024 at 10:31 > *To: *Andy Goryachev <andy.goryac...@oracle.com> > <andy.goryac...@oracle.com>, Johan Vos <johan....@gluonhq.com> > <johan....@gluonhq.com>, openjfx-dev <openjfx-dev@openjdk.org> > <openjfx-dev@openjdk.org> > *Subject: *Re: [External] : Re: consistent naming for tests > > Perhaps it is something Eclipse does differently. Normally nested classed > are numbered ($1, $2), so perhaps ecj is compiling these with differently > filenames. > > --John > > On 09/07/2024 17:37, Andy Goryachev wrote: > > Have you tried building in Eclipse on the latest Linux Mint? Or building > on an EncFS mount? > > > > I don't know why Mint decided to use EncFS knowing its issues, and I > suppose I can try fixing my setup (it's a default Mint installation), but I > was quite surprised myself and thought that it might be just as easy to fix > the tests... here is how the fix might look: > > > > https://github.com/andy-goryachev-oracle/jfx/pull/9 > <https://urldefense.com/v3/__https:/github.com/andy-goryachev-oracle/jfx/pull/9__;!!ACWV5N9M2RV99hQ!LaBncRdN0CNaCaX9i-HN9Ahy_JisIzv8qRh2QTWilcD8X42VuKB6KAjQhVsUxYY9XfQoGwBjmYhOucrVx_tv1PGChmrX$> > > > > -andy > > > > *From: *John Hendrikx <john.hendr...@gmail.com> <john.hendr...@gmail.com> > *Date: *Tuesday, July 9, 2024 at 08:22 > *To: *Andy Goryachev <andy.goryac...@oracle.com> > <andy.goryac...@oracle.com>, Johan Vos <johan....@gluonhq.com> > <johan....@gluonhq.com>, openjfx-dev <openjfx-dev@openjdk.org> > <openjfx-dev@openjdk.org> > *Subject: *[External] : Re: consistent naming for tests > > > > On 09/07/2024 16:52, Andy Goryachev wrote: > > > > Two test files consistently generate an error in Eclipse > > - ObservableValueFluentBindingsTest > - LazyObjectBindingTest > > > > I admit I have a weird setup (EncFS on Linux Mint running on MacBook Pro), > and it only manifests itself in Eclipse and not in the gradle build - > perhaps Eclipse actually verifies the removal of files? > > > > Anyway, a suggestion - if you use @Nested, please keep the class names > *short*. > > This is not an Eclipse bug as I never encounter such issues. 143 > characters is rather short these days, but I suppose we could limit the > nesting a bit. Still, I'd look into a way to alleviate this problem in > your setup, sooner or later this is going to be a problem. > > --John > >
