On Fri, 19 Jan 2024 10:21:05 GMT, John Hendrikx wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> constructe
On Fri, 19 Jan 2024 18:12:26 GMT, Kevin Rushforth wrote:
> I note that we could still consider deprecating the `SimpleSelector` and
> `CompoundSelector` classes for _eventual_ removal, but it wouldn't have to be
> done in such a rush.
That's certainly true, the only reason we wanted to do a qu
On Fri, 19 Jan 2024 10:21:05 GMT, John Hendrikx wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> constructe
On Fri, 19 Jan 2024 18:12:26 GMT, Kevin Rushforth wrote:
> I note that we could still consider deprecating the `SimpleSelector` and
> `CompoundSelector` classes for _eventual_ removal
I like the idea of deprecating with the following removal, coupled with adding
the "missing" APIs to Selector.
On Fri, 19 Jan 2024 10:21:05 GMT, John Hendrikx wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> constructe
On Fri, 19 Jan 2024 10:21:05 GMT, John Hendrikx wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> constructe
On Fri, 19 Jan 2024 10:21:05 GMT, John Hendrikx wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> constructe
On Fri, 19 Jan 2024 15:37:33 GMT, Andy Goryachev wrote:
>> @andy-goryachev-oracle Scenic View source code doesn't use neither of them.
>>
>> However, Scene Builder does:
>> https://github.com/gluonhq/scenebuilder/blob/master/kit/src/main/java/com/oracle/javafx/scenebuilder/kit/util/CssInternal.
On Fri, 19 Jan 2024 09:50:44 GMT, Jose Pereda wrote:
> However, Scene Builder does:
Thank you, @jperedadnr !
Does this mean that we ought to add a public method to Selector?
-
PR Comment: https://git.openjdk.org/jfx/pull/1333#issuecomment-1900643988
On Fri, 19 Jan 2024 09:52:23 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/javafx/css/Selector.java line 179:
>>
>>> 177: * @throws IOException if reading from {@code DataInputStream}
>>> fails
>>> 178: */
>>> 179: protected static Selector readBinary(int bssV
> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>
> This can be done with only a minor API break, as `SimpleSelector` and
> `CompoundSelector` were public before. However, these classes could not be
> constructed by 3rd parties. The only way to access them was by doing a
On Thu, 18 Jan 2024 23:55:56 GMT, Kevin Rushforth wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> construc
On Fri, 19 Jan 2024 00:00:32 GMT, Kevin Rushforth wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> construc
On Fri, 19 Jan 2024 00:43:20 GMT, Andy Goryachev wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> construct
On Thu, 18 Jan 2024 23:58:17 GMT, Kevin Rushforth wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> construc
On Sun, 14 Jan 2024 14:54:36 GMT, John Hendrikx wrote:
> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>
> This can be done with only a minor API break, as `SimpleSelector` and
> `CompoundSelector` were public before. However, these classes could not be
> constructed by
On Sun, 14 Jan 2024 14:54:36 GMT, John Hendrikx wrote:
> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>
> This can be done with only a minor API break, as `SimpleSelector` and
> `CompoundSelector` were public before. However, these classes could not be
> constructed by
On Sun, 14 Jan 2024 14:54:36 GMT, John Hendrikx wrote:
> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>
> This can be done with only a minor API break, as `SimpleSelector` and
> `CompoundSelector` were public before. However, these classes could not be
> constructed by
18 matches
Mail list logo
