On Fri, 19 Jan 2024 15:37:33 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> @andy-goryachev-oracle Scenic View source code doesn't use neither of them. >> >> However, Scene Builder does: >> https://github.com/gluonhq/scenebuilder/blob/master/kit/src/main/java/com/oracle/javafx/scenebuilder/kit/util/CssInternal.java#L251 >> >> I guess it can be used a quick test of this PR? > >> However, Scene Builder does: > > Thank you, @jperedadnr ! > Does this mean that we ought to add a public method to Selector? > @andy-goryachev-oracle Scenic View source code doesn't use neither of them. > > However, Scene Builder does: > https://github.com/gluonhq/scenebuilder/blob/master/kit/src/main/java/com/oracle/javafx/scenebuilder/kit/util/CssInternal.java#L251 > > I guess it can be used a quick test of this PR? Well, because those classes are moved, SceneBuilder would no longer work (probably something like a class not found exception will occur). Is SceneBuilder tied to JavaFX releases? Otherwise we may need to take more action. I see that SceneBuilder is using these classes to obtain a list of all style classes that are part of a style sheet. Such functionality could be offered in several places, either on `Stylesheet`, which gathers all the style classes, a public method on `Rule` which gets all style classes that the rule uses, or a public method on `Selector` which returns all style classes that the selector uses. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1333#issuecomment-1900697708
