On Tue, 6 Dec 2022 09:00:02 GMT, John Hendrikx wrote:
>>> This is one giant pull request, somewhat difficult on the reviewers,
>>> especially since we have to go through it several times.
>>>
>>> It would be _much_ easier for the reviewers to deal with one fix per PR,
>>> especially in the cas
On Tue, 6 Dec 2022 08:54:26 GMT, John Hendrikx wrote:
>> I don't see it as a useful warning. The code isn't necessarily better
>> without, and can be less clear. I think this might argue for asking Eclipse
>> users to disable this warning in the IDE.
>
> @kevinrushforth Is this okay as it is?
On Tue, 6 Dec 2022 06:39:32 GMT, Nir Lisker wrote:
>> Since this is an internal class (not public API), I won't object to this
>> change. I do think it's a rather pointless change, but I'll leave it up to
>> you.
>
> Personally, I find that re-declaring type hierarchy is clutter. I can see why
On Tue, 6 Dec 2022 06:33:20 GMT, Nir Lisker wrote:
>> I agree with you - we shouldn't.
>
> This is an example of what I was talking about in [this
> comment](https://github.com/openjdk/jfx/pull/958#pullrequestreview-1198517697).
I agree that no follow-on bug is needed.
-
PR: https
On Sat, 3 Dec 2022 20:54:04 GMT, John Hendrikx wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be auto
On Sat, 3 Dec 2022 20:46:22 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/LinuxStatefulMultiTouchProcessor.java
>> line 42:
>>
>>> 40:
>>> 41: private final Map slotToIDMap =
>>> 42: new HashMap<>();
>>
>> Same line. There are more
On Mon, 5 Dec 2022 22:20:59 GMT, John Hendrikx wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix indentations and merge short lines
>
>> This is one giant pull request, somewhat difficult on the reviewers,
>> e
On Tue, 22 Nov 2022 22:30:16 GMT, Kevin Rushforth wrote:
>> I agree. The problem is that we will not be able to enable the warning in
>> IDE, or it has to be @suppressed.
>>
>> So the choice is either fix the code and enable warning, or keep the code as
>> is and disable the warning.
>
> I do
On Wed, 30 Nov 2022 12:55:08 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/UploadingPainter.java
>> line 41:
>>
>>> 39: * The PresentingPainter is used when we are rendering to the main
>>> screen.
>>> 40: */
>>> 41: final class UploadingPaint
On Mon, 5 Dec 2022 22:20:59 GMT, John Hendrikx wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix indentations and merge short lines
>
>> This is one giant pull request, somewhat difficult on the reviewers,
>> e
On Tue, 6 Dec 2022 03:03:13 GMT, Andy Goryachev wrote:
>> The code was already broken (since 2014 apparently when the new Base64
>> decoder was used). Had the author turned on these handy warnings, they
>> would have noticed that something was amiss. Now they unwittingly changed
>> the behav
On Mon, 5 Dec 2022 22:00:01 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/application/LauncherImpl.java
>> line 601:
>>
>>> 599: }
>>> 600: args.add("--" + k + "=" + (v != null ? v : ""));
>>> 601: idx++;
>>
>> I suspect t
On Sat, 3 Dec 2022 20:54:04 GMT, John Hendrikx wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be auto
On Sat, 3 Dec 2022 20:54:04 GMT, John Hendrikx wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be auto
On Mon, 5 Dec 2022 19:59:45 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix indentations and merge short lines
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/application/LauncherI
On Mon, 5 Dec 2022 20:17:04 GMT, Andy Goryachev wrote:
>> I do agree with @kevinrushforth here.
>>
>> It might be borderline useful to enable the warning once just to see if
>> there are any bugs or perhaps to clean up the most obvious cases, but it
>> probably makes little sense to enable the
On Mon, 5 Dec 2022 21:40:40 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/font/PrismFontFile.java
>> line 586:
>>
>>> 584: ascent = -(float)hhea.getShort(4);
>>> 585: descent = -(float)hhea.getShort(6);
>>> 586:
On Mon, 5 Dec 2022 21:46:12 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/javafx/css/CssParser.java line 2579:
>>
>>> 2577: term = nextLayer(lastTerm);
>>> 2578: }
>>> 2579: return new ParsedValueImpl<>(layers,
>>> CornerRadiiConverter.getInstanc
On Mon, 5 Dec 2022 20:37:09 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix indentations and merge short lines
>
> modules/javafx.graphics/src/main/java/com/sun/prism/d3d/D3DContext.java li
On Mon, 5 Dec 2022 20:11:53 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix indentations and merge short lines
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/font/PrismFontFile.ja
On Tue, 22 Nov 2022 22:34:42 GMT, Andy Goryachev wrote:
>> I don't see it as a useful warning. The code isn't necessarily better
>> without, and can be less clear. I think this might argue for asking Eclipse
>> users to disable this warning in the IDE.
>
> I do agree with @kevinrushforth here.
On Sat, 3 Dec 2022 20:54:04 GMT, John Hendrikx wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be auto
On Sat, 3 Dec 2022 20:54:04 GMT, John Hendrikx wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be auto
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autoboxed)
> - Remove unnecessary semi-colons (at end of class d
24 matches
Mail list logo
