On Tue, 6 Dec 2022 09:00:02 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>>> This is one giant pull request, somewhat difficult on the reviewers, >>> especially since we have to go through it several times. >>> >>> It would be _much_ easier for the reviewers to deal with one fix per PR, >>> especially in the cases where more than 30 files are going to be touched. >>> >>> For example, changes involving diamond operator and missing @OVERRIDES >>> could have been made into two separate PRs, making it a breeze to review >>> and integrate, while also cutting down on the number of files which >>> contained non-trivial changes. >>> >>> What do you think? >> >> Agreed, they'll be smaller and more focused in the future. > >> @hjohn Kevin has outstanding requests. Even though you can technically >> integrate, you should resolve these with him. > > Yes, I will wait until @kevinrushforth had time to take another look. good job @hjohn ! ------------- PR: https://git.openjdk.org/jfx/pull/960
