Re: RFR: JDK-8283401: ArrayIndexOutOfBoundsException when disconnecting screen(s)

2023-08-11 Thread Marius Hanl
On Sat, 5 Aug 2023 13:00:36 GMT, Marius Hanl wrote: > When the `D3DPipeline` is reinitialized, the adapter ordinal of all the > `Screen`s are outdated. > As a consequence, when a `D3DResourceFactory` is created for a `Screen` > (adapter ordinal), the code may fail with an `ArrayIndexOutOfBounds

Re: RFR: JDK-8283401: ArrayIndexOutOfBoundsException when disconnecting screen(s)

2023-08-11 Thread Michael Strauß
On Sat, 5 Aug 2023 13:00:36 GMT, Marius Hanl wrote: > When the `D3DPipeline` is reinitialized, the adapter ordinal of all the > `Screen`s are outdated. > As a consequence, when a `D3DResourceFactory` is created for a `Screen` > (adapter ordinal), the code may fail with an `ArrayIndexOutOfBounds

Re: RFR: JDK-8283401: ArrayIndexOutOfBoundsException when disconnecting screen(s)

2023-08-11 Thread Kevin Rushforth
On Sat, 5 Aug 2023 13:00:36 GMT, Marius Hanl wrote: > When the `D3DPipeline` is reinitialized, the adapter ordinal of all the > `Screen`s are outdated. > As a consequence, when a `D3DResourceFactory` is created for a `Screen` > (adapter ordinal), the code may fail with an `ArrayIndexOutOfBounds

Re: RFR: JDK-8283401: ArrayIndexOutOfBoundsException when disconnecting screen(s)

2023-08-09 Thread Kevin Rushforth
On Wed, 9 Aug 2023 20:12:48 GMT, Michael Strauß wrote: > > I actually considered this but I really want to keep the diff in this PR as > > small as possible, as this is a very sensitive area. If something is broken > > here, it will affect a lot of Windows users. IMO this is a good idea for a

Re: RFR: JDK-8283401: ArrayIndexOutOfBoundsException when disconnecting screen(s)

2023-08-09 Thread Michael Strauß
On Wed, 9 Aug 2023 20:03:04 GMT, Marius Hanl wrote: > I actually considered this but I really want to keep the diff in this PR as > small as possible, as this is a very sensitive area. If something is broken > here, it will affect a lot of Windows users. IMO this is a good idea for a > follow

Re: RFR: JDK-8283401: ArrayIndexOutOfBoundsException when disconnecting screen(s)

2023-08-09 Thread Marius Hanl
On Wed, 9 Aug 2023 18:46:11 GMT, Michael Strauß wrote: > I notice that the logic to assign adapter ordinals is now duplicated in two > places in the codebase. Have you thought about moving the implementation into > the `Screen` class? I actually considered this but I really want to keep the d

Re: RFR: JDK-8283401: ArrayIndexOutOfBoundsException when disconnecting screen(s)

2023-08-09 Thread Michael Strauß
On Sat, 5 Aug 2023 13:00:36 GMT, Marius Hanl wrote: > When the `D3DPipeline` is reinitialized, the adapter ordinal of all the > `Screen`s are outdated. > As a consequence, when a `D3DResourceFactory` is created for a `Screen` > (adapter ordinal), the code may fail with an `ArrayIndexOutOfBounds

Re: RFR: JDK-8283401: ArrayIndexOutOfBoundsException when disconnecting screen(s)

2023-08-05 Thread Kevin Rushforth
On Sat, 5 Aug 2023 13:00:36 GMT, Marius Hanl wrote: > When the `D3DPipeline` is reinitialized, the adapter ordinal of all the > `Screen`s are outdated. > As a consequence, when a `D3DResourceFactory` is created for a `Screen` > (adapter ordinal), the code may fail with an `ArrayIndexOutOfBounds