On Wed, 9 Aug 2023 20:12:48 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
> > I actually considered this but I really want to keep the diff in this PR as > > small as possible, as this is a very sensitive area. If something is broken > > here, it will affect a lot of Windows users. IMO this is a good idea for a > > follow up PR, as soon as this one is merged. > > Wouldn't this just impose the compatibility risk again onto the next PR? The > diff is very small in both cases. I prefer the approach taken in this PR to minimize the diffs. One benefit is that I could imagine, for example, wanting to backport this small fix once it is integrated and has baked for a while. I would have no desire to backport what is otherwise just a refactoring to eliminate duplicate code. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1200#issuecomment-1672207340
