On Wed, 9 Jul 2025 05:01:14 GMT, Alexander Zuev wrote:
>> - Copyright year update;
>> - Introduce new function requestNodeAttribute and refactor code to use it;
>> - Fix some typos;
>> - Enable new code to handle TabPages since TabGroup was implemented;
>
> Alexander Zuev has updated the pull req
On Wed, 9 Jul 2025 05:01:14 GMT, Alexander Zuev wrote:
>> - Copyright year update;
>> - Introduce new function requestNodeAttribute and refactor code to use it;
>> - Fix some typos;
>> - Enable new code to handle TabPages since TabGroup was implemented;
>
> Alexander Zuev has updated the pull req
On Wed, 9 Jul 2025 15:43:01 GMT, Alexander Zuev wrote:
>> but it will save a couple of nanoseconds!
>>
>> the code is ok. one question though: what are the circumstances when these
>> calls would return NULL?
>
> 1. Custom component that has no role assigned at all
> 2. Exception happens on Ja
On Wed, 9 Jul 2025 14:54:48 GMT, Andy Goryachev wrote:
>> But that would require two conditions - one for position and one for size -
>> with the same logic which would look not that compact and pretty.
>
> but it will save a couple of nanoseconds!
>
> the code is ok. one question though: what
On Wed, 9 Jul 2025 04:15:56 GMT, Alexander Zuev wrote:
>> modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line
>> 50:
>>
>>> 48: [rolesMap setObject:@"JFXButtonAccessibility"
>>> forKey:@"SPLIT_MENU_BUTTON"];
>>> 49: [rolesMap setObject:@"JFXRadiobuttonAccessibi
On Wed, 9 Jul 2025 05:01:14 GMT, Alexander Zuev wrote:
>> - Copyright year update;
>> - Introduce new function requestNodeAttribute and refactor code to use it;
>> - Fix some typos;
>> - Enable new code to handle TabPages since TabGroup was implemented;
>
> Alexander Zuev has updated the pull req
> - Copyright year update;
> - Introduce new function requestNodeAttribute and refactor code to use it;
> - Fix some typos;
> - Enable new code to handle TabPages since TabGroup was implemented;
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last re
On Tue, 8 Jul 2025 21:33:00 GMT, Andy Goryachev wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove explicit jresult declaration
>
> modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line
On Tue, 8 Jul 2025 21:31:14 GMT, Andy Goryachev wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reverting the curly bracket placement
>
> modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m li
> - Copyright year update;
> - Introduce new function requestNodeAttribute and refactor code to use it;
> - Fix some typos;
> - Enable new code to handle TabPages since TabGroup was implemented;
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last re
On Tue, 8 Jul 2025 21:29:31 GMT, Andy Goryachev wrote:
>> - Copyright year update;
>> - Introduce new function requestNodeAttribute and refactor code to use it;
>> - Fix some typos;
>> - Enable new code to handle TabPages since TabGroup was implemented;
>
> modules/javafx.graphics/src/main/native
On Thu, 3 Jul 2025 22:17:01 GMT, Alexander Zuev wrote:
> - Copyright year update;
> - Introduce new function requestNodeAttribute and refactor code to use it;
> - Fix some typos;
> - Enable new code to handle TabPages since TabGroup was implemented;
I don't see any obvious issues in the monkey t
On Thu, 3 Jul 2025 22:17:01 GMT, Alexander Zuev wrote:
> - Copyright year update;
> - Introduce new function requestNodeAttribute and refactor code to use it;
> - Fix some typos;
> - Enable new code to handle TabPages since TabGroup was implemented;
Like this very much, a good cleanup.
modules/
On Thu, 3 Jul 2025 22:17:01 GMT, Alexander Zuev wrote:
> - Copyright year update;
> - Introduce new function requestNodeAttribute and refactor code to use it;
> - Fix some typos;
> - Enable new code to handle TabPages since TabGroup was implemented;
modules/javafx.graphics/src/main/native-glass/
On Thu, 3 Jul 2025 22:17:01 GMT, Alexander Zuev wrote:
> - Copyright year update;
> - Introduce new function requestNodeAttribute and refactor code to use it;
> - Fix some typos;
> - Enable new code to handle TabPages since TabGroup was implemented;
@andy-goryachev-oracle @arapte please review
15 matches
Mail list logo
