On Wed, 16 Apr 2025 16:45:32 GMT, Andy Goryachev wrote:
>> `Parent.needsLayout` is implemented with a `ReadOnlyBooleanWrapper`. The
>> property getter returns the wrapper itself, but what it should be doing is
>> return the read-only getter instead.
>>
>> A single reviewer should be sufficient
On Wed, 16 Apr 2025 16:45:32 GMT, Andy Goryachev wrote:
> Looks good.
>
> Do you know if there is an easy way to find similar issues elsewhere?
Nothing comes to mind, short of checking all usages of the *Wrapper
implementations.
-
PR Comment: https://git.openjdk.org/jfx/pull/1780
On Wed, 16 Apr 2025 08:59:55 GMT, Michael Strauß wrote:
> `Parent.needsLayout` is implemented with a `ReadOnlyBooleanWrapper`. The
> property getter returns the wrapper itself, but what it should be doing is
> return the read-only getter instead.
>
> A single reviewer should be sufficient.
Se
On Wed, 16 Apr 2025 08:59:55 GMT, Michael Strauß wrote:
> `Parent.needsLayout` is implemented with a `ReadOnlyBooleanWrapper`. The
> property getter returns the wrapper itself, but what it should be doing is
> return the read-only getter instead.
>
> A single reviewer should be sufficient.
Lo
On Wed, 16 Apr 2025 10:10:36 GMT, Ambarish Rapte wrote:
>> `Parent.needsLayout` is implemented with a `ReadOnlyBooleanWrapper`. The
>> property getter returns the wrapper itself, but what it should be doing is
>> return the read-only getter instead.
>>
>> A single reviewer should be sufficient
On Wed, 16 Apr 2025 08:59:55 GMT, Michael Strauß wrote:
> `Parent.needsLayout` is implemented with a `ReadOnlyBooleanWrapper`. The
> property getter returns the wrapper itself, but what it should be doing is
> return the read-only getter instead.
>
> A single reviewer should be sufficient.
Ma
On Wed, 16 Apr 2025 08:59:55 GMT, Michael Strauß wrote:
> `Parent.needsLayout` is implemented with a `ReadOnlyBooleanWrapper`. The
> property getter returns the wrapper itself, but what it should be doing is
> return the read-only getter instead.
>
> A single reviewer should be sufficient.
lg
