On Sat, 12 Apr 2025 20:01:44 GMT, Michael Strauß wrote:
> By the way, can I interest you in a review of this PR?
Yes, I already partially checked it out, and was intending to do a closer
review soon.
-
PR Comment: https://git.openjdk.org/jfx/pull/1655#issuecomment-2799045186
On Sat, 12 Apr 2025 18:32:57 GMT, John Hendrikx wrote:
> With some minimal style changes (and a hack to change the window border to
> dark mode on Windows) I get this out of modena.css:
Nice! Once we have a per-scene color scheme, I plan to have window borders
adjust to the color scheme of the
On Fri, 11 Apr 2025 22:57:51 GMT, Andy Goryachev wrote:
> > You seem to be arguing against media queries themselves
>
> Probably. I am afraid the CSS subsystem will grow into a monster (I mean, it
> already is).
>
> The follow up question is what you guys think about updating `modena.css` to
On Fri, 11 Apr 2025 22:57:51 GMT, Andy Goryachev wrote:
> > You seem to be arguing against media queries themselves
>
> Probably. I am afraid the CSS subsystem will grow into a monster (I mean, it
> already is).
It is, and it’s held together by duct tape in many places. That’s why I think
we
On Thu, 10 Apr 2025 16:44:38 GMT, Michael Strauß wrote:
> You seem to be arguing against media queries themselves
Probably. I am afraid the CSS subsystem will grow into a monster (I mean, it
already is).
The follow up question is what you guys think about updating `modena.css` to
support the
> Implementation of [CSS media
> queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7).
Michael Strauß has updated the pull request incrementally with one additional
commit since the last revision:
add more tests
-
Changes:
- all: https://git.openjdk.org/jfx
On Thu, 10 Apr 2025 16:07:05 GMT, Andy Goryachev wrote:
> Also, would it be possible to add Goals and Non-Goals to the .md, make it
> more JEP-like?
I added the two sections.
-
PR Comment: https://git.openjdk.org/jfx/pull/1655#issuecomment-2794556758
On Thu, 10 Apr 2025 16:05:53 GMT, Andy Goryachev wrote:
> In the .md document, you make a reference to w3.org media queries, so one
> question comes right away: do you eventually plan to implement the whole spec
> as defined there, or we are really talking about a very small subset of
> featur
On Thu, 10 Apr 2025 10:05:37 GMT, Michael Strauß wrote:
>> Implementation of [CSS media
>> queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add mor
