On Thu, 1 May 2025 15:39:03 GMT, Kevin Rushforth wrote:
>> I understand the argument for `TextLineInfo`, I guess I'm looking more at
>> `LayoutInfo` here. My question is whether it is really the best choice to
>> sacrifice local consistency within a single class just to have it look more
>> si
On Mon, 7 Apr 2025 19:14:40 GMT, Michael Strauß wrote:
>> `TextLineInfo` is a record, I don't want to add duplicate getXXX() aliases
>> there.
>>
>> The other (in `LayoutInfo`) are modeled after `Text`/`TextFlow` (e.g.
>> `underlineShape()`), I have no problem with any of these. I don't think
On Sat, 5 Apr 2025 07:49:07 GMT, Michael Strauß wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 48 commits:
>>
>> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api
>> - Merge remote-
On Mon, 7 Apr 2025 18:54:00 GMT, Michael Strauß wrote:
> I think a class should always be final or sealed by default
contr-argument: testing. having extendable classes makes it easier to mock,
although in the case of a platform your argument carries greater weight.
I can make it `sealed`.
--
On Sat, 5 Apr 2025 07:53:35 GMT, Michael Strauß wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 48 commits:
>>
>> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api
>> - Merge remote-
On Mon, 7 Apr 2025 18:39:25 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/CaretInfo.java line
>> 62:
>>
>>> 60: * {@code (index < 0 || index > getSegmentCount())}
>>> 61: */
>>> 62: public abstract Rectangle2D getSegmentAt(int index);
>>
On Mon, 7 Apr 2025 18:30:47 GMT, Andy Goryachev wrote:
> > Can this class be sealed?
>
> Theoretically, yes, but what problem would that solve?
>
> I can understand when sealing would make the platform more secure, but in
> this case I see no value whatsoever. Could you give me an example wher
On Fri, 4 Apr 2025 14:42:20 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs no
On Fri, 4 Apr 2025 14:42:20 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs no
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
10 matches
Mail list logo
