Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v3]

2024-05-07 Thread eduardsdv
On Mon, 6 May 2024 18:05:06 GMT, Andy Goryachev wrote: >> I agree with you, at least with scrolling when clicking on the scrollbar >> track. >> I would like to change the amount of scroll pixels to the viewport length. >> >> PageUp/PageDown not only scrolls the view, but also moves the >> sel

Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v3]

2024-05-06 Thread eduardsdv
On Mon, 6 May 2024 08:49:27 GMT, Florian Kirmaier wrote: >> As seen in the unit test of the PR, when we click on the area above/below >> the scrollbar the position jumps - but the jump is now not always consistent. >> In the current version on the last cell - the UI always jumps to the top. In

Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v3]

2024-05-06 Thread Andy Goryachev
On Mon, 6 May 2024 17:54:44 GMT, eduardsdv wrote: > PageUp/PageDown not only scrolls the view, but also moves the > selection/focus, so it makes sense to align the cells up/down. You are right about focus/selection! This brings up another question: for accessibility reasons, do we want to add

Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v3]

2024-05-06 Thread eduardsdv
On Mon, 6 May 2024 08:49:27 GMT, Florian Kirmaier wrote: >> As seen in the unit test of the PR, when we click on the area above/below >> the scrollbar the position jumps - but the jump is now not always consistent. >> In the current version on the last cell - the UI always jumps to the top. In

Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v3]

2024-05-06 Thread Andy Goryachev
On Mon, 6 May 2024 08:49:27 GMT, Florian Kirmaier wrote: >> As seen in the unit test of the PR, when we click on the area above/below >> the scrollbar the position jumps - but the jump is now not always consistent. >> In the current version on the last cell - the UI always jumps to the top. In

Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v3]

2024-05-06 Thread eduardsdv
On Mon, 6 May 2024 16:35:14 GMT, Andy Goryachev wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8323511: Fix scrolling when clicking the scrollbar track when only one >> cell is visible > > modules/javafx.

Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v3]

2024-05-06 Thread eduardsdv
On Mon, 6 May 2024 16:34:22 GMT, Andy Goryachev wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8323511: Fix scrolling when clicking the scrollbar track when only one >> cell is visible > > modules/javafx.

Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v3]

2024-05-06 Thread Andy Goryachev
On Mon, 6 May 2024 08:49:27 GMT, Florian Kirmaier wrote: >> As seen in the unit test of the PR, when we click on the area above/below >> the scrollbar the position jumps - but the jump is now not always consistent. >> In the current version on the last cell - the UI always jumps to the top. In

Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v3]

2024-05-06 Thread eduardsdv
On Mon, 6 May 2024 08:49:27 GMT, Florian Kirmaier wrote: >> As seen in the unit test of the PR, when we click on the area above/below >> the scrollbar the position jumps - but the jump is now not always consistent. >> In the current version on the last cell - the UI always jumps to the top. In

Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v3]

2024-05-06 Thread Florian Kirmaier
> As seen in the unit test of the PR, when we click on the area above/below the > scrollbar the position jumps - but the jump is now not always consistent. > In the current version on the last cell - the UI always jumps to the top. In > the other cases, the assumed default cell height is used. >