Re: RFR: 8323077: C type error (incompatible function pointer) in X11GLContext.c [v2]

2024-01-08 Thread Florian Weimer
On Mon, 8 Jan 2024 17:15:39 GMT, Kevin Rushforth wrote: > Thanks for addressing it as well. `glXGetProcAddress` is defined in > `glxext.h`, which we include in our sources. See [glxext.h line > 155](https://github.com/openjdk/jfx/blob/master/modules/javafx.graphics/src/main/native-prism-es2/GL/

Re: RFR: 8323077: C type error (incompatible function pointer) in X11GLContext.c [v2]

2024-01-08 Thread Kevin Rushforth
On Mon, 8 Jan 2024 10:19:08 GMT, Florian Weimer wrote: >> 8323077: C type error (incompatible function pointer) in X11GLContext.c > > Florian Weimer has updated the pull request incrementally with one additional > commit since the last revision: > > Suppress -Wpointer-sign warning > I wanted

Re: RFR: 8323077: C type error (incompatible function pointer) in X11GLContext.c [v2]

2024-01-08 Thread Florian Weimer
> 8323077: C type error (incompatible function pointer) in X11GLContext.c Florian Weimer has updated the pull request incrementally with one additional commit since the last revision: Suppress -Wpointer-sign warning - Changes: - all: https://git.openjdk.org/jfx/pull/1319/files

Re: RFR: 8323077: C type error (incompatible function pointer) in X11GLContext.c

2024-01-08 Thread Florian Weimer
On Sat, 6 Jan 2024 16:42:19 GMT, Kevin Rushforth wrote: > Looks good. In looking at the logs from the GHA run I can see that the > warning is gone. > > I note that there is an additional warning on that same line: > > ``` > 2024-01-05T23:04:38.0399339Z > /home/runner/work/jfx/jfx/jfx/modules/

Re: RFR: 8323077: C type error (incompatible function pointer) in X11GLContext.c

2024-01-06 Thread Kevin Rushforth
On Fri, 5 Jan 2024 17:01:25 GMT, Florian Weimer wrote: > 8323077: C type error (incompatible function pointer) in X11GLContext.c Looks good. In looking at the logs from the GHA run I can see that the warning is gone. I note that there is an additional warning on that same line: 2024-01-05T