On Mon, 8 Jan 2024 10:19:08 GMT, Florian Weimer <fwei...@openjdk.org> wrote:
>> 8323077: C type error (incompatible function pointer) in X11GLContext.c > > Florian Weimer has updated the pull request incrementally with one additional > commit since the last revision: > > Suppress -Wpointer-sign warning > I wanted to make the minimal change to fix the build error. Always a good idea. The reason I mentioned the other warning is that the two warnings are very related (both are type mismatches due to missing casts). > I can add the cast to const GLubyte *, but I couldn't find an official > prototype for the glXGetProcAddress function, so I'm not sure if it's > consistent across OpenGL implementations. Thanks for addressing it as well. `glXGetProcAddress` is defined in `glxext.h`, which we include in our sources. See [glxext.h line 155](https://github.com/openjdk/jfx/blob/master/modules/javafx.graphics/src/main/native-prism-es2/GL/glxext.h#L155) ------------- Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1319#pullrequestreview-1809646203
