Re: RFR: 8319079: Missing range checks in decora [v2]

2023-11-01 Thread Jayathirth D V
On Tue, 31 Oct 2023 14:54:01 GMT, Kevin Rushforth wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add common util function > > modules/javafx.graphics/src/main/native-decora/SSEUtils.cc line 187: > >> 185: } >>

Re: RFR: 8319079: Missing range checks in decora [v2]

2023-10-31 Thread Kevin Rushforth
On Tue, 31 Oct 2023 05:55:56 GMT, Jayathirth D V wrote: >> In SW pipeline path of Box/Gaussian Blur/Shadow effects we are not checking >> for range when we read data from the source/destination buffers in native >> code. >> >> We need to add appropriate range checks in native JNI code also apa

Re: RFR: 8319079: Missing range checks in decora [v2]

2023-10-30 Thread Jayathirth D V
> In SW pipeline path of Box/Gaussian Blur/Shadow effects we are not checking > for range when we read data from the source/destination buffers in native > code. > > We need to add appropriate range checks in native JNI code also apart from > range checks in Java side to make sure that wherever

Re: RFR: 8319079: Missing range checks in decora [v2]

2023-10-30 Thread Jayathirth D V
On Mon, 30 Oct 2023 15:16:45 GMT, Kevin Rushforth wrote: >> modules/javafx.graphics/src/main/native-decora/SSELinearConvolveShadowPeer.cc >> line 133: >> >>> 131: dstrows > srcrows) { // We should not move out of source >>> vertical bounds >>> 132: return; >>> 133: } >> >>