On Thu, 8 Jun 2023 17:44:21 GMT, Karthik P K wrote:
> All the tests added here passes with the fix and fails without it. No issues
> now. Could have been some problem from my end.
Alright, thanks for the feedback!
-
PR Comment: https://git.openjdk.org/jfx/pull/1150#issuecomment-15
On Thu, 8 Jun 2023 15:59:13 GMT, Marius Hanl wrote:
>> This PR does two small improvements to `VirtualFlow`.
>> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
>> `computeWidth` methods, although a fixed cell size is set and we therefore
>> don't need to call those method (
On Thu, 8 Jun 2023 06:47:44 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
>> line 1954:
>>
>>> 1952: * Gets the breadth of a specific cell
>>> 1953: */
>>> 1954: double getCellBreadth(T cell) {
>>
>> is there a possibi
On Thu, 8 Jun 2023 15:59:13 GMT, Marius Hanl wrote:
>> This PR does two small improvements to `VirtualFlow`.
>> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
>> `computeWidth` methods, although a fixed cell size is set and we therefore
>> don't need to call those method (
On Thu, 8 Jun 2023 15:59:13 GMT, Marius Hanl wrote:
>> This PR does two small improvements to `VirtualFlow`.
>> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
>> `computeWidth` methods, although a fixed cell size is set and we therefore
>> don't need to call those method (
> This PR does two small improvements to `VirtualFlow`.
> Until now, the `VirtualFlow` sometimes called the `computeHeight` or
> `computeWidth` methods, although a fixed cell size is set and we therefore
> don't need to call those method (and never should do, as we may don't get the
> expected r
