On Mon, 21 Aug 2023 18:25:08 GMT, Karthik P K wrote:
>> The text run selected in `PrismTextLayout::getHitInfo()` method for
>> character index calculation was not correct when Text node was embedded in
>> TextFlow. Hence wrong character index value was calculated for the same.
>>
>> Since only
On Mon, 21 Aug 2023 18:20:17 GMT, Karthik P K wrote:
>> The text run selected in `PrismTextLayout::getHitInfo()` method for
>> character index calculation was not correct when Text node was embedded in
>> TextFlow. Hence wrong character index value was calculated for the same.
>>
>> Since only
On Mon, 21 Aug 2023 14:40:09 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismTextLayout.java
> line 782:
>
>>
> The text run selected in `PrismTextLayout::getHitInfo()` method for character
> index calculation was not correct when Text node was embedded in TextFlow.
> Hence wrong character index value was calculated for the same.
>
> Since only x, y coordinates were available in the above mentioned meth
On Mon, 21 Aug 2023 14:01:06 GMT, Karthik P K wrote:
>> The text run selected in `PrismTextLayout::getHitInfo()` method for
>> character index calculation was not correct when Text node was embedded in
>> TextFlow. Hence wrong character index value was calculated for the same.
>>
>> Since only
On Mon, 21 Aug 2023 14:01:06 GMT, Karthik P K wrote:
>> The text run selected in `PrismTextLayout::getHitInfo()` method for
>> character index calculation was not correct when Text node was embedded in
>> TextFlow. Hence wrong character index value was calculated for the same.
>>
>> Since only
On Wed, 16 Aug 2023 20:32:54 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix character index calculation issue when Text node content is wrapped
>
> modules/javafx.graphics/src/main/java/com/
On Wed, 16 Aug 2023 20:15:05 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix character index calculation issue when Text node content is wrapped
>
> modules/javafx.graphics/src/main/java/com/
> The text run selected in `PrismTextLayout::getHitInfo()` method for character
> index calculation was not correct when Text node was embedded in TextFlow.
> Hence wrong character index value was calculated for the same.
>
> Since only x, y coordinates were available in the above mentioned meth
On Tue, 8 Aug 2023 13:57:31 GMT, Karthik P K wrote:
>> The text run selected in `PrismTextLayout::getHitInfo()` method for
>> character index calculation was not correct when Text node was embedded in
>> TextFlow. Hence wrong character index value was calculated for the same.
>>
>> Since only
On Fri, 30 Jun 2023 14:40:14 GMT, Karthik P K wrote:
>> The text run selected in `PrismTextLayout::getHitInfo()` method for
>> character index calculation was not correct when Text node was embedded in
>> TextFlow. Hence wrong character index value was calculated for the same.
>>
>> Since only
> The text run selected in `PrismTextLayout::getHitInfo()` method for character
> index calculation was not correct when Text node was embedded in TextFlow.
> Hence wrong character index value was calculated for the same.
>
> Since only x, y coordinates were available in the above mentioned meth
On Sun, 2 Jul 2023 09:53:58 GMT, Karthik P K wrote:
> However I agree that bug is present in the character index calculation like
> you mentioned above. I'll work on fixing that.
Correction: The character index calculation looks to be correct when x
coordinate passed to it is correct.
One more
On Fri, 30 Jun 2023 17:21:59 GMT, Andy Goryachev wrote:
> Do you mean MouseVent.getX()?
The x coordinate reported by `MouseEvent.getPickResult().getIntersectedPoint()`
method. I can reproduce this issue in MonkeyTester as well. When I checked the
`Point2D` object sent to `Text::hitTest()` met
On Fri, 30 Jun 2023 14:40:14 GMT, Karthik P K wrote:
>> The text run selected in `PrismTextLayout::getHitInfo()` method for
>> character index calculation was not correct when Text node was embedded in
>> TextFlow. Hence wrong character index value was calculated for the same.
>>
>> Since only
On Fri, 30 Jun 2023 15:56:45 GMT, Karthik P K wrote:
> Looks like there is issue in MouseEvent or PickResult.
Do you mean MouseVent.getX()? I cannot reproduce that (in the Monkey Tester).
I've added a mouse handler to the control (Text or TextFlow, depending on the
page) and ev.getX() always
On Fri, 30 Jun 2023 14:40:14 GMT, Karthik P K wrote:
>> The text run selected in `PrismTextLayout::getHitInfo()` method for
>> character index calculation was not correct when Text node was embedded in
>> TextFlow. Hence wrong character index value was calculated for the same.
>>
>> Since only
> The text run selected in `PrismTextLayout::getHitInfo()` method for character
> index calculation was not correct when Text node was embedded in TextFlow.
> Hence wrong character index value was calculated for the same.
>
> Since only x, y coordinates were available in the above mentioned meth
On Tue, 27 Jun 2023 17:56:09 GMT, Andy Goryachev wrote:
> right. in the case of the (highlighted) emoji character - the insertion index
> starts with 0 which I think cannot be correct, because all of the text should
> be added as a single Text instance, see
>
If a Text node's content is wrappe
On Tue, 27 Jun 2023 17:49:48 GMT, Karthik P K wrote:
> The insertion index is reported relative to the Text's text incase of Text
> node.
right. in the case of the (highlighted) emoji character - the insertion index
starts with 0 which I think cannot be correct, because all of the text should
On Tue, 27 Jun 2023 16:13:03 GMT, Andy Goryachev wrote:
> I think not only it shows incorrect insertion index when you move the mouse
> across that emoji (in Text.hitTest goes from 0 to 1, while expected change is
> 2), but I think it's also wrong because that emoji is the last symbol in that
On Tue, 27 Jun 2023 16:06:18 GMT, Karthik P K wrote:
>> The text run selected in `PrismTextLayout::getHitInfo()` method for
>> character index calculation was not correct when Text node was embedded in
>> TextFlow. Hence wrong character index value was calculated for the same.
>>
>> Since only
On Tue, 27 Jun 2023 15:30:39 GMT, Karthik P K wrote:
>> The text run selected in `PrismTextLayout::getHitInfo()` method for
>> character index calculation was not correct when Text node was embedded in
>> TextFlow. Hence wrong character index value was calculated for the same.
>>
>> Since only
> The text run selected in `PrismTextLayout::getHitInfo()` method for character
> index calculation was not correct when Text node was embedded in TextFlow.
> Hence wrong character index value was calculated for the same.
>
> Since only x, y coordinates were available in the above mentioned meth
> The text run selected in `PrismTextLayout::getHitInfo()` method for character
> index calculation was not correct when Text node was embedded in TextFlow.
> Hence wrong character index value was calculated for the same.
>
> Since only x, y coordinates were available in the above mentioned meth
On Wed, 21 Jun 2023 06:34:00 GMT, Karthik P K wrote:
> The text run selected in `PrismTextLayout::getHitInfo()` method for character
> index calculation was not correct when Text node was embedded in TextFlow.
> Hence wrong character index value was calculated for the same.
>
> Since only x, y
On Wed, 21 Jun 2023 22:59:41 GMT, Andy Goryachev wrote:
>> The text run selected in `PrismTextLayout::getHitInfo()` method for
>> character index calculation was not correct when Text node was embedded in
>> TextFlow. Hence wrong character index value was calculated for the same.
>>
>> Since o
On Wed, 21 Jun 2023 06:34:00 GMT, Karthik P K wrote:
> The text run selected in `PrismTextLayout::getHitInfo()` method for character
> index calculation was not correct when Text node was embedded in TextFlow.
> Hence wrong character index value was calculated for the same.
>
> Since only x, y
28 matches
Mail list logo
