> The text run selected in `PrismTextLayout::getHitInfo()` method for character > index calculation was not correct when Text node was embedded in TextFlow. > Hence wrong character index value was calculated for the same. > > Since only x, y coordinates were available in the above mentioned method, > sending the text as a parameter to this method is necessary so as to know if > the text run selected for character index calculation is correct. Along with > this change modified the `PrismTextLayout::getHitInfo()` method to calculate > the correct character index. > > Added tests to validate the changes.
Karthik P K has updated the pull request incrementally with one additional commit since the last revision: Review comments ------------- Changes: - all: https://git.openjdk.org/jfx/pull/1157/files - new: https://git.openjdk.org/jfx/pull/1157/files/1a5e23fc..158ab65b Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1157&range=05 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1157&range=04-05 Stats: 46 lines in 3 files changed: 20 ins; 15 del; 11 mod Patch: https://git.openjdk.org/jfx/pull/1157.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1157/head:pull/1157 PR: https://git.openjdk.org/jfx/pull/1157