On Thu, 23 Mar 2023 08:31:41 GMT, Florian Kirmaier
wrote:
>> When an exception is logged in JavaFX, then the exception is kept in a
>> reference.
>> This way, always the last logged exception is retained.
>>
>> This is a memory-leak.
>> This was done to write unit-tests to ensure certain error
On Sat, 11 Mar 2023 14:28:31 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8303740
>> Added changes based on code review
>
> modules/javafx.base/src/main/java/com/sun/javafx/binding
On Thu, 23 Mar 2023 08:31:41 GMT, Florian Kirmaier
wrote:
>> When an exception is logged in JavaFX, then the exception is kept in a
>> reference.
>> This way, always the last logged exception is retained.
>>
>> This is a memory-leak.
>> This was done to write unit-tests to ensure certain error
> When an exception is logged in JavaFX, then the exception is kept in a
> reference.
> This way, always the last logged exception is retained.
>
> This is a memory-leak.
> This was done to write unit-tests to ensure certain error-cases are logged.
>
> A simple fix is, to add a flag, to enable/d
On Wed, 8 Mar 2023 08:19:25 GMT, John Hendrikx wrote:
> IMHO, the `Logging` class should also not be there, as it is just a facade
> for `PlatformLogger` specifically there for these tests.
>
> The tests took the easy way out here to test for log messages by modifying
> production code to use
On Tue, 7 Mar 2023 11:59:20 GMT, Florian Kirmaier wrote:
> When an exception is logged in JavaFX, then the exception is kept in a
> reference.
> This way, always the last logged exception is retained.
>
> This is a memory-leak.
> This was done to write unit-tests to ensure certain error-cases a
On Tue, 7 Mar 2023 11:59:20 GMT, Florian Kirmaier wrote:
> When an exception is logged in JavaFX, then the exception is kept in a
> reference.
> This way, always the last logged exception is retained.
>
> This is a memory-leak.
> This was done to write unit-tests to ensure certain error-cases a
On Wed, 8 Mar 2023 08:19:25 GMT, John Hendrikx wrote:
>> I think it's cleaner, to just have nothing in production.
>> The flag is a bit ugly - just aesthetically, but I don't think it's a
>> problem.
>
>> I think it's cleaner, to just have nothing in production. The flag is a bit
>> ugly - just
On Wed, 8 Mar 2023 07:53:22 GMT, Florian Kirmaier wrote:
> I think it's cleaner, to just have nothing in production. The flag is a bit
> ugly - just aesthetically, but I don't think it's a problem.
IMHO, the `Logging` class should also not be there, as it is just a facade for
`PlatformLogger`
On Tue, 7 Mar 2023 11:59:20 GMT, Florian Kirmaier wrote:
> When an exception is logged in JavaFX, then the exception is kept in a
> reference.
> This way, always the last logged exception is retained.
>
> This is a memory-leak.
> This was done to write unit-tests to ensure certain error-cases a
On Tue, 7 Mar 2023 11:59:20 GMT, Florian Kirmaier wrote:
> When an exception is logged in JavaFX, then the exception is kept in a
> reference.
> This way, always the last logged exception is retained.
>
> This is a memory-leak.
> This was done to write unit-tests to ensure certain error-cases a
On Tue, 7 Mar 2023 11:59:20 GMT, Florian Kirmaier wrote:
> When an exception is logged in JavaFX, then the exception is kept in a
> reference.
> This way, always the last logged exception is retained.
>
> This is a memory-leak.
> This was done to write unit-tests to ensure certain error-cases a
On Tue, 7 Mar 2023 11:59:20 GMT, Florian Kirmaier wrote:
> When an exception is logged in JavaFX, then the exception is kept in a
> reference.
> This way, always the last logged exception is retained.
>
> This is a memory-leak.
> This was done to write unit-tests to ensure certain error-cases a
13 matches
Mail list logo
