On Wed, 8 Mar 2023 07:53:22 GMT, Florian Kirmaier <fkirma...@openjdk.org> wrote:
> I think it's cleaner, to just have nothing in production. The flag is a bit > ugly - just aesthetically, but I don't think it's a problem. IMHO, the `Logging` class should also not be there, as it is just a facade for `PlatformLogger` specifically there for these tests. The tests took the easy way out here to test for log messages by modifying production code to use a different logger (and introducing a leak by doing so). An alternative would be to install a `LoggerFinder` only when tests run, and allow this to be inspected. ------------- PR: https://git.openjdk.org/jfx/pull/1053
