Re: RFR: 8301219: JavaFX crash when closing with the escape key [v3]

2023-12-24 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 19:15:03 GMT, Martin Fox wrote: >> While processing a key down event the Glass GTK code sends out PRESSED and >> TYPED KeyEvents back to back. If the stage is closed during the PRESSED >> event the code will end up referencing freed memory while sending out the >> TYPED eve

Re: RFR: 8301219: JavaFX crash when closing with the escape key [v3]

2023-12-24 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 19:15:03 GMT, Martin Fox wrote: >> While processing a key down event the Glass GTK code sends out PRESSED and >> TYPED KeyEvents back to back. If the stage is closed during the PRESSED >> event the code will end up referencing freed memory while sending out the >> TYPED eve

Re: RFR: 8301219: JavaFX crash when closing with the escape key [v3]

2023-12-23 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 19:15:03 GMT, Martin Fox wrote: >> While processing a key down event the Glass GTK code sends out PRESSED and >> TYPED KeyEvents back to back. If the stage is closed during the PRESSED >> event the code will end up referencing freed memory while sending out the >> TYPED eve

Re: RFR: 8301219: JavaFX crash when closing with the escape key [v3]

2023-12-21 Thread Kevin Rushforth
On Mon, 18 Dec 2023 19:15:03 GMT, Martin Fox wrote: >> While processing a key down event the Glass GTK code sends out PRESSED and >> TYPED KeyEvents back to back. If the stage is closed during the PRESSED >> event the code will end up referencing freed memory while sending out the >> TYPED eve

Re: RFR: 8301219: JavaFX crash when closing with the escape key [v2]

2023-12-18 Thread Kevin Rushforth
On Fri, 15 Dec 2023 20:57:01 GMT, Martin Fox wrote: >> While processing a key down event the Glass GTK code sends out PRESSED and >> TYPED KeyEvents back to back. If the stage is closed during the PRESSED >> event the code will end up referencing freed memory while sending out the >> TYPED eve

Re: RFR: 8301219: JavaFX crash when closing with the escape key [v3]

2023-12-18 Thread Martin Fox
> While processing a key down event the Glass GTK code sends out PRESSED and > TYPED KeyEvents back to back. If the stage is closed during the PRESSED event > the code will end up referencing freed memory while sending out the TYPED > event. This can lead to intermittent crashes. > > In GlassAp

Re: RFR: 8301219: JavaFX crash when closing with the escape key [v3]

2023-12-18 Thread Kevin Rushforth
On Mon, 18 Dec 2023 19:15:03 GMT, Martin Fox wrote: >> While processing a key down event the Glass GTK code sends out PRESSED and >> TYPED KeyEvents back to back. If the stage is closed during the PRESSED >> event the code will end up referencing freed memory while sending out the >> TYPED eve

Re: RFR: 8301219: JavaFX crash when closing with the escape key [v2]

2023-12-18 Thread Martin Fox
On Mon, 18 Dec 2023 13:22:07 GMT, Kevin Rushforth wrote: >> Martin Fox has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Debugging code turned off by default. Empty line removed. > > modules/javafx.graphics/src/main/native-glass/gtk/Delete

Re: RFR: 8301219: JavaFX crash when closing with the escape key [v2]

2023-12-15 Thread Martin Fox
> While processing a key down event the Glass GTK code sends out PRESSED and > TYPED KeyEvents back to back. If the stage is closed during the PRESSED event > the code will end up referencing freed memory while sending out the TYPED > event. This can lead to intermittent crashes. > > In GlassAp

Re: RFR: 8301219: JavaFX crash when closing with the escape key

2023-12-15 Thread Kevin Rushforth
On Thu, 14 Dec 2023 00:58:56 GMT, Martin Fox wrote: > While processing a key down event the Glass GTK code sends out PRESSED and > TYPED KeyEvents back to back. If the stage is closed during the PRESSED event > the code will end up referencing freed memory while sending out the TYPED > event.