On Mon, 18 Dec 2023 13:22:07 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Martin Fox has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Debugging code turned off by default. Empty line removed. > > modules/javafx.graphics/src/main/native-glass/gtk/DeletedMemDebug.h line 46: > >> 44: static void operator delete[](void* ptr, std::size_t sz) >> 45: { >> 46: ::memset(ptr, 0xcc, sz); > > Should this use `FILL` instead of hard-coded `0xcc`? Yes, it should use FILL. Will fix. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1307#discussion_r1430550148