Re: RFR: 8296589: PixelBufferDrawTest fails on some systems [v2]

2022-11-13 Thread Lukasz Kostyra
On Thu, 10 Nov 2022 14:56:17 GMT, Lukasz Kostyra wrote: >> Issue happening on some hardware due to slightly different pixel values >> being returned. >> >> Increased tolerance of asserts in compareColor function to allow these tests >> to pass (0.01 delta is still tighter than other similar te

Re: RFR: 8296589: PixelBufferDrawTest fails on some systems [v2]

2022-11-12 Thread Kevin Rushforth
On Thu, 10 Nov 2022 14:56:17 GMT, Lukasz Kostyra wrote: >> Issue happening on some hardware due to slightly different pixel values >> being returned. >> >> Increased tolerance of asserts in compareColor function to allow these tests >> to pass (0.01 delta is still tighter than other similar te

Re: RFR: 8296589: PixelBufferDrawTest fails on some systems [v2]

2022-11-12 Thread Kevin Rushforth
On Thu, 10 Nov 2022 14:56:17 GMT, Lukasz Kostyra wrote: >> Issue happening on some hardware due to slightly different pixel values >> being returned. >> >> Increased tolerance of asserts in compareColor function to allow these tests >> to pass (0.01 delta is still tighter than other similar te

Re: RFR: 8296589: PixelBufferDrawTest fails on some systems [v2]

2022-11-10 Thread Andy Goryachev
On Thu, 10 Nov 2022 14:56:17 GMT, Lukasz Kostyra wrote: >> Issue happening on some hardware due to slightly different pixel values >> being returned. >> >> Increased tolerance of asserts in compareColor function to allow these tests >> to pass (0.01 delta is still tighter than other similar te

Re: RFR: 8296589: PixelBufferDrawTest fails on some systems [v2]

2022-11-10 Thread Lukasz Kostyra
> Issue happening on some hardware due to slightly different pixel values being > returned. > > Increased tolerance of asserts in compareColor function to allow these tests > to pass (0.01 delta is still tighter than other similar tests which use 0.07). Lukasz Kostyra has updated the pull reque

Re: RFR: 8296589: PixelBufferDrawTest fails on some systems

2022-11-10 Thread Lukasz Kostyra
On Wed, 9 Nov 2022 19:14:10 GMT, Andy Goryachev wrote: >> tests/system/src/test/java/test/robot/javafx/scene/PixelBufferDrawTest.java >> line 189: >> >>> 187: >>> 188: private void compareColor(Color exp, Color act) { >>> 189: Assert.assertEquals(exp.getRed(), act.getRed(), 0.01);

Re: RFR: 8296589: PixelBufferDrawTest fails on some systems

2022-11-10 Thread Lukasz Kostyra
On Wed, 9 Nov 2022 18:30:26 GMT, Kevin Rushforth wrote: >> tests/system/src/test/java/test/robot/javafx/scene/PixelBufferDrawTest.java >> line 189: >> >>> 187: >>> 188: private void compareColor(Color exp, Color act) { >>> 189: Assert.assertEquals(exp.getRed(), act.getRed(), 0.01);

Re: RFR: 8296589: PixelBufferDrawTest fails on some systems

2022-11-09 Thread Andy Goryachev
On Wed, 9 Nov 2022 18:00:31 GMT, Lukasz Kostyra wrote: > Issue happening on some hardware due to slightly different pixel values being > returned. > > Increased tolerance of asserts in compareColor function to allow these tests > to pass (0.01 delta is still tighter than other similar tests wh

Re: RFR: 8296589: PixelBufferDrawTest fails on some systems

2022-11-09 Thread Andy Goryachev
On Wed, 9 Nov 2022 18:38:27 GMT, Kevin Rushforth wrote: >> Issue happening on some hardware due to slightly different pixel values >> being returned. >> >> Increased tolerance of asserts in compareColor function to allow these tests >> to pass (0.01 delta is still tighter than other similar te

Re: RFR: 8296589: PixelBufferDrawTest fails on some systems

2022-11-09 Thread Kevin Rushforth
On Wed, 9 Nov 2022 18:00:31 GMT, Lukasz Kostyra wrote: > Issue happening on some hardware due to slightly different pixel values being > returned. > > Increased tolerance of asserts in compareColor function to allow these tests > to pass (0.01 delta is still tighter than other similar tests wh

Re: RFR: 8296589: PixelBufferDrawTest fails on some systems

2022-11-09 Thread Kevin Rushforth
On Wed, 9 Nov 2022 18:05:22 GMT, Andy Goryachev wrote: >> Issue happening on some hardware due to slightly different pixel values >> being returned. >> >> Increased tolerance of asserts in compareColor function to allow these tests >> to pass (0.01 delta is still tighter than other similar tes