On Thu, 10 Nov 2022 14:56:17 GMT, Lukasz Kostyra <d...@openjdk.org> wrote:

>> Issue happening on some hardware due to slightly different pixel values 
>> being returned.
>> 
>> Increased tolerance of asserts in compareColor function to allow these tests 
>> to pass (0.01 delta is still tighter than other similar tests which use 
>> 0.07).
>
> Lukasz Kostyra has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains one commit:
> 
>   8296589: PixelBufferDrawTest fails on some systems
>   
>   Issue happening on some hardware due to slightly different pixel values 
> being returned.
>   
>   Increased tolerance of asserts in compareColor function to allow these 
> tests to pass
>   (0.01 delta is tighter than other tests which use 0.07).

> > lukostyra force-pushed the JDK-8296589-PixelBufferDrawTest-tolerance branch 
> > from 
> > [46665a4](https://github.com/openjdk/jfx/commit/46665a4c47257cf350475007e56d67d073df8741)
> >  to 
> > [082cd74](https://github.com/openjdk/jfx/commit/082cd74054b683dd20a6b428bc2d4aeeeff476f4)
> 
> @lukostyra Please don't force push to your branch once the PR has been 
> published as `rfr`. See item 3 of [the pull request section in 
> CONTRIBUTING.md](https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md#submitting-your-changes-via-a-pull-request).

Sorry about that! I'll make sure to not do it in the future.

-------------

PR: https://git.openjdk.org/jfx/pull/944

Reply via email to