On Wed, 16 Aug 2023 06:01:45 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasan
On Mon, 7 Aug 2023 08:52:01 GMT, John Hendrikx wrote:
>>> > > both windows (using EmbeddedFrameBug class listed earlier) shows O100%
>>> > > for primary retina screen (should be 200%).
>>> >
>>> >
>>> > @hjohn Seems like @andy-goryachev-oracle is telling it regressed after
>>> > `updateSceneS
On Wed, 16 Aug 2023 06:01:45 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasan
On Wed, 16 Aug 2023 06:01:45 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasan
On Tue, 15 Aug 2023 14:41:16 GMT, Andy Goryachev wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Duplicate code removal
>
> modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java line 630:
>
>>
> When the JavaFX scene is set before it is really shown, then the scale
> factors are not properly propagated to the EmbeddedWindow, resulting in
> showing wrong scales.
> Fix is made to update scales to EmbeddedWindow
Prasanta Sadhukhan has updated the pull request incrementally with one
addi
On Fri, 4 Aug 2023 06:21:55 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasant
On Fri, 4 Aug 2023 06:21:55 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasant
On Mon, 7 Aug 2023 09:30:47 GMT, Prasanta Sadhukhan
wrote:
> Since this PR solves issue 2 issues in windows and has not regressed anything
> in mac (behaves same before and after fix), can we commit this and raise a
> windows-toolkit JBS issue for mac to see why render scale is not updated for
On Thu, 3 Aug 2023 18:05:52 GMT, Andy Goryachev wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Call updateSceneState with lock and in FX thread
>
> src="https://github.com/openjdk/jfx/assets/107069028/57b97
On Mon, 7 Aug 2023 08:52:01 GMT, John Hendrikx wrote:
> Are you sure it works correctly on Windows now?
I have tested EmbeddedFrameBug in windows10 with primary scale 1.25 and
secondary scale 1.75 and it worked for me..
-
PR Comment: https://git.openjdk.org/jfx/pull/1171#issuecomm
On Mon, 7 Aug 2023 08:23:35 GMT, Prasanta Sadhukhan
wrote:
> > > > both windows (using EmbeddedFrameBug class listed earlier) shows O100%
> > > > for primary retina screen (should be 200%).
> > >
> > >
> > > @hjohn Seems like @andy-goryachev-oracle is telling it regressed after
> > > `update
On Mon, 7 Aug 2023 07:56:27 GMT, John Hendrikx wrote:
> > > both windows (using EmbeddedFrameBug class listed earlier) shows O100%
> > > for primary retina screen (should be 200%).
> >
> >
> > @hjohn Seems like @andy-goryachev-oracle is telling it regressed after
> > `updateSceneState` integr
On Fri, 4 Aug 2023 06:21:55 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasant
On Fri, 4 Aug 2023 05:46:35 GMT, Prasanta Sadhukhan
wrote:
> both windows (using EmbeddedFrameBug class listed earlier) shows O100% for
> primary retina screen (should be 200%).
@hjohn Seems like @andy-goryachev-oracle is telling it regressed after
`updateSceneState` integration as previousl
On Fri, 4 Aug 2023 06:21:55 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasant
On Thu, 3 Aug 2023 17:55:14 GMT, Andy Goryachev wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Call updateSceneState with lock and in FX thread
>
> modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPa
> When the JavaFX scene is set before it is really shown, then the scale
> factors are not properly propagated to the EmbeddedWindow, resulting in
> showing wrong scales.
> Fix is made to update scales to EmbeddedWindow
Prasanta Sadhukhan has updated the pull request incrementally with one
addi
On Thu, 3 Aug 2023 18:04:23 GMT, Andy Goryachev wrote:
> The good:
>
> * image on both monitors (macOS) appear with no gaps
>
> * text on both monitors looks good, anti-aliasing works as expected
>
>
> The bad:
>
> * both windows (using EmbeddedFrameBug class listed earlier) show
On Thu, 3 Aug 2023 04:06:04 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasant
On Thu, 3 Aug 2023 04:06:04 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasant
On Thu, 3 Aug 2023 04:06:04 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasant
> When the JavaFX scene is set before it is really shown, then the scale
> factors are not properly propagated to the EmbeddedWindow, resulting in
> showing wrong scales.
> Fix is made to update scales to EmbeddedWindow
Prasanta Sadhukhan has updated the pull request incrementally with one
addi
On Wed, 2 Aug 2023 04:24:37 GMT, Prasanta Sadhukhan
wrote:
> Only question I have is, should updateSceneState be called in
> QuantumToolkit.runWithRenderLock synchronization?
We probably do need to acquire the lock. All but one call to that method is
done with the `renderLock` held. A bigger
On Wed, 2 Aug 2023 04:24:37 GMT, Prasanta Sadhukhan
wrote:
> I think JDK-8274932 is about scale correction and JDK-809 is about
> content refresh in different-scaled configuration so I dont think one is
> duplicate of another.
OK, thanks for doing the `/issue add` then. Don't forget do th
On Tue, 1 Aug 2023 10:25:33 GMT, John Hendrikx wrote:
> @prsadhuk @hjohn I'll take a closer look early next week, but I think the
> best way forward might be for Prasanta to evaluate #1189 and, if the modified
> fix in that PR is what we want to use, update _this_ PR to include the change
> th
> When the JavaFX scene is set before it is really shown, then the scale
> factors are not properly propagated to the EmbeddedWindow, resulting in
> showing wrong scales.
> Fix is made to update scales to EmbeddedWindow
Prasanta Sadhukhan has updated the pull request incrementally with one
addi
On Tue, 1 Aug 2023 04:46:31 GMT, Prasanta Sadhukhan
wrote:
> > @prsadhuk @hjohn I'll take a closer look early next week, but I think the
> > best way forward might be for Prasanta to evaluate #1189 and, if the
> > modified fix in that PR is what we want to use, update _this_ PR to include
> >
On Sat, 29 Jul 2023 15:11:34 GMT, Kevin Rushforth wrote:
> @prsadhuk @hjohn I'll take a closer look early next week, but I think the
> best way forward might be for Prasanta to evaluate #1189 and, if the modified
> fix in that PR is what we want to use, update _this_ PR to include the change
>
On Fri, 28 Jul 2023 03:53:17 GMT, Prasanta Sadhukhan
wrote:
>> This is how I understand this works:
>>
>> The `JFXPanel` makes use of an `EmbeddedWindow` that is a subclass of
>> `Window`. This window listens to its `showing` property, and when it
>> becomes visible will call `updateOutputS
On Tue, 11 Jul 2023 07:58:07 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasan
On Thu, 27 Jul 2023 17:50:11 GMT, John Hendrikx wrote:
> This is how I understand this works:
>
> The `JFXPanel` makes use of an `EmbeddedWindow` that is a subclass of
> `Window`. This window listens to its `showing` property, and when it becomes
> visible will call `updateOutputScales`; this
On Tue, 11 Jul 2023 07:58:07 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasan
On Tue, 11 Jul 2023 07:58:07 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasan
On Tue, 11 Jul 2023 07:58:07 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasan
> When the JavaFX scene is set before it is really shown, then the scale
> factors are not properly propagated to the EmbeddedWindow, resulting in
> showing wrong scales.
> Fix is made to update scales to EmbeddedWindow
Prasanta Sadhukhan has updated the pull request with a new target base due t
On Mon, 10 Jul 2023 06:54:49 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasan
> When the JavaFX scene is set before it is really shown, then the scale
> factors are not properly propagated to the EmbeddedWindow, resulting in
> showing wrong scales.
> Fix is made to update scales to EmbeddedWindow
Prasanta Sadhukhan has updated the pull request with a new target base due t
> When the JavaFX scene is set before it is really shown, then the scale
> factors are not properly propagated to the EmbeddedWindow, resulting in
> showing wrong scales.
> Fix is made to update scales to EmbeddedWindow
Prasanta Sadhukhan has updated the pull request incrementally with one
addi
On Fri, 7 Jul 2023 17:18:10 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasant
On Fri, 7 Jul 2023 17:18:10 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasant
On Fri, 7 Jul 2023 17:46:18 GMT, Andy Goryachev wrote:
> 1. please merge the master branch
>
> 2. to avoid [JDK-809](https://bugs.openjdk.org/browse/JDK-809)
> condition, I am launching separate windows on all monitors. What I see is
> that the label text on the secondary monitor
On Fri, 7 Jul 2023 17:18:10 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasant
On Fri, 7 Jul 2023 17:07:55 GMT, Andy Goryachev wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Set stage scale in FX thread
>> - Set stage scale in FX thread
>
> modules/javafx.swing/src/main/java/javafx/
> When the JavaFX scene is set before it is really shown, then the scale
> factors are not properly propagated to the EmbeddedWindow, resulting in
> showing wrong scales.
> Fix is made to update scales to EmbeddedWindow
Prasanta Sadhukhan has updated the pull request incrementally with one
addi
> When the JavaFX scene is set before it is really shown, then the scale
> factors are not properly propagated to the EmbeddedWindow, resulting in
> showing wrong scales.
> Fix is made to update scales to EmbeddedWindow
Prasanta Sadhukhan has updated the pull request incrementally with two
addi
On Fri, 7 Jul 2023 17:07:57 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasant
On Fri, 7 Jul 2023 16:42:58 GMT, Prasanta Sadhukhan
wrote:
> You need to run with this change
Does not help.
I think the problem is that FX stage is being manipulated from the EDT, see the
comment in JFXPanel:607 and the FX stage access on JFXPanel:640.
You probably need to wrap the follo
On Fri, 7 Jul 2023 16:41:09 GMT, Prasanta Sadhukhan
wrote:
> Exception in thread "AWT-EventQueue-0" java.lang.IllegalStateException: Not
> on FX application thread; currentThread = AWT-EventQueue-0
> at
> javafx.graphics/com.sun.javafx.tk.Toolkit.checkFxUserThread(Toolkit.java:293)
>
On Thu, 6 Jul 2023 13:10:44 GMT, Prasanta Sadhukhan
wrote:
> When the JavaFX scene is set before it is really shown, then the scale
> factors are not properly propagated to the EmbeddedWindow, resulting in
> showing wrong scales.
> Fix is made to update scales to EmbeddedWindow
> Testing on M
On Thu, 6 Jul 2023 13:10:44 GMT, Prasanta Sadhukhan
wrote:
> When the JavaFX scene is set before it is really shown, then the scale
> factors are not properly propagated to the EmbeddedWindow, resulting in
> showing wrong scales.
> Fix is made to update scales to EmbeddedWindow
Appearance wit
On Thu, 6 Jul 2023 13:10:44 GMT, Prasanta Sadhukhan
wrote:
> When the JavaFX scene is set before it is really shown, then the scale
> factors are not properly propagated to the EmbeddedWindow, resulting in
> showing wrong scales.
> Fix is made to update scales to EmbeddedWindow
Testing on Mac
On Thu, 6 Jul 2023 13:10:44 GMT, Prasanta Sadhukhan
wrote:
> When the JavaFX scene is set before it is really shown, then the scale
> factors are not properly propagated to the EmbeddedWindow, resulting in
> showing wrong scales.
> Fix is made to update scales to EmbeddedWindow
@prsadhuk coul
53 matches
Mail list logo
