Re: RFR: 8169285: Re-enable javafx.swt tests [v2]

2025-05-01 Thread Kevin Rushforth
On Thu, 1 May 2025 13:54:49 GMT, Kevin Rushforth wrote: > I will check whether this is the case by trying out HelloFXCanvas after first > setting that variable. If so, then the fix for > [JDK-8340378](https://bugs.openjdk.org/browse/JDK-8340378) will be to set > that env variable from HelloFXC

Re: RFR: 8169285: Re-enable javafx.swt tests [v2]

2025-05-01 Thread Kevin Rushforth
On Wed, 30 Apr 2025 21:53:38 GMT, Marius Hanl wrote: > I setup an Ubuntu 24.04.2 LTS inside WSL, did export GDK_BACKEND=x11 > (otherwise I always got a crash). Interesting. The crash is likely due to [JDK-8340378](https://bugs.openjdk.org/browse/JDK-8340378). JavaFX glass calls `putenv("GDK_B

Re: RFR: 8169285: Re-enable javafx.swt tests [v2]

2025-04-30 Thread Marius Hanl
On Thu, 24 Apr 2025 16:55:58 GMT, Kevin Rushforth wrote: > I confirm that this runs fine on my Windows 11 system. > > @Maran23 what platforms did you test this on? Windows? > > I fired off a CI headful test run, and I see the following failure on Ubuntu > 22.04: I setup an Ubuntu 24.04.2 LTS

Re: RFR: 8169285: Re-enable javafx.swt tests [v2]

2025-04-24 Thread Kevin Rushforth
On Wed, 16 Apr 2025 21:17:16 GMT, Marius Hanl wrote: >> With this change, you can now run the `swt` tests as easy as: `:swt:test >> -PSWT_TEST=true`. >> ![image](https://github.com/user-attachments/assets/928141b5-ac81-4b15-9d86-5ea87f47c1c4) >> >> Note: At one point `IS_FULL_TEST` was used as

Re: RFR: 8169285: Re-enable javafx.swt tests [v2]

2025-04-18 Thread Marius Hanl
> With this change, you can now run the `swt` tests as easy as: `:swt:test > -PSWT_TEST=true`. > ![image](https://github.com/user-attachments/assets/928141b5-ac81-4b15-9d86-5ea87f47c1c4) > > Note: At one point `IS_FULL_TEST` was used as well for the enablement of the > tests. I don't see any rea

Re: RFR: 8169285: Re-enable javafx.swt tests [v2]

2025-04-17 Thread Andy Goryachev
On Wed, 16 Apr 2025 21:17:16 GMT, Marius Hanl wrote: >> With this change, you can now run the `swt` tests as easy as: `:swt:test >> -PSWT_TEST=true`. >> ![image](https://github.com/user-attachments/assets/928141b5-ac81-4b15-9d86-5ea87f47c1c4) >> >> Note: At one point `IS_FULL_TEST` was used as

Re: RFR: 8169285: Re-enable javafx.swt tests [v2]

2025-04-16 Thread Marius Hanl
On Wed, 16 Apr 2025 20:26:17 GMT, Kevin Rushforth wrote: >> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8169285: SWT tests should run with IS_FULL_TEST > > build.gradle line 3085: > >> 3083: >> 3084: test { >> 3085:

Re: RFR: 8169285: Re-enable javafx.swt tests [v2]

2025-04-16 Thread Kevin Rushforth
On Wed, 16 Apr 2025 21:30:11 GMT, Andy Goryachev wrote: > yes, we still need `SWT_TEST` so we can disable it on mac. If that flag is the mechanism we need to use to disable it on macOS, then we will need the following additional change: // Specifies whether to run system tests that depend on

Re: RFR: 8169285: Re-enable javafx.swt tests [v2]

2025-04-16 Thread Kevin Rushforth
On Wed, 16 Apr 2025 21:51:42 GMT, Kevin Rushforth wrote: > > yes, we still need `SWT_TEST` so we can disable it on mac. > > If that flag is the mechanism we need to use to disable it on macOS, then we > will need the following additional change: > > ``` > // Specifies whether to run system te

Re: RFR: 8169285: Re-enable javafx.swt tests [v2]

2025-04-16 Thread Kevin Rushforth
On Wed, 16 Apr 2025 21:22:28 GMT, Kevin Rushforth wrote: > we can leave it enabled by default, in which case the only flag you would > need is -PFULL_TEST=true. I realize my statement might be ambiguous. I am not suggesting further changes to build.gradle: you can leave it as: enabled =

Re: RFR: 8169285: Re-enable javafx.swt tests [v2]

2025-04-16 Thread Kevin Rushforth
On Wed, 16 Apr 2025 21:17:16 GMT, Marius Hanl wrote: >> With this change, you can now run the `swt` tests as easy as: `:swt:test >> -PSWT_TEST=true`. >> ![image](https://github.com/user-attachments/assets/928141b5-ac81-4b15-9d86-5ea87f47c1c4) >> >> Note: At one point `IS_FULL_TEST` was used as