On Wed, 16 Apr 2025 21:17:16 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> With this change, you can now run the `swt` tests as easy as: `:swt:test >> -PSWT_TEST=true`. >>  >> >> Note: At one point `IS_FULL_TEST` was used as well for the enablement of the >> tests. I don't see any reason for it, and one flag seems to be enough to me. >> But open for opinions on this one. > > Marius Hanl has updated the pull request incrementally with one additional > commit since the last revision: > > 8169285: SWT tests should run with IS_FULL_TEST I was curious as to why the tests were being run on GHA without your setting the `SWT_TEST` flag, and then spotted this in `build.gradle`, line 502: // Specifies whether to run system tests that depend on SWT (only used when FULL_TEST is also enabled) defineProperty("SWT_TEST", "true") So even though we have a flag, it is on by default (which makes me wonder why we bothered with a flag). If the tests are stable, which will need to be tested (I can do a CI build tomorrow), we can leave it enabled by default, in which case the only flag you would need is `-PFULL_TEST=true`. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1783#issuecomment-2810825722
