Re: RFR: JDK-8320444: Column drag header is positioned wrong for nested columns [v2]

2023-11-21 Thread Karthik P K
On Tue, 21 Nov 2023 20:03:31 GMT, Marius Hanl wrote: >> When a nested column is dragged, the column drag header (blue) is positioned >> wrong. >> It appears at the very left of the table and not where the column is. >> >> ![image](https://github.com/openjdk/jfx/assets/66004280/6c2a0f61-f32d-4c3

Re: RFR: JDK-8320444: Column drag header is positioned wrong for nested columns [v2]

2023-11-21 Thread Michael Strauß
On Tue, 21 Nov 2023 20:03:31 GMT, Marius Hanl wrote: >> When a nested column is dragged, the column drag header (blue) is positioned >> wrong. >> It appears at the very left of the table and not where the column is. >> >> ![image](https://github.com/openjdk/jfx/assets/66004280/6c2a0f61-f32d-4c3

Re: RFR: JDK-8320444: Column drag header is positioned wrong for nested columns [v2]

2023-11-21 Thread Andy Goryachev
On Tue, 21 Nov 2023 20:03:31 GMT, Marius Hanl wrote: >> When a nested column is dragged, the column drag header (blue) is positioned >> wrong. >> It appears at the very left of the table and not where the column is. >> >> ![image](https://github.com/openjdk/jfx/assets/66004280/6c2a0f61-f32d-4c3

Re: RFR: JDK-8320444: Column drag header is positioned wrong for nested columns [v2]

2023-11-21 Thread Andy Goryachev
On Tue, 21 Nov 2023 20:00:56 GMT, Marius Hanl wrote: >> good point. >> >> May I suggest to declare constants for column widths and column reordering >> coordinates so the origin of these numbers becomes clear? >> Also, we are comparing floating point numbers, so perhaps it's better >> specify

Re: RFR: JDK-8320444: Column drag header is positioned wrong for nested columns [v2]

2023-11-21 Thread Marius Hanl
> When a nested column is dragged, the column drag header (blue) is positioned > wrong. > It appears at the very left of the table and not where the column is. > > ![image](https://github.com/openjdk/jfx/assets/66004280/6c2a0f61-f32d-4c38-9549-e2e20f5bd4f8) > > The fix is to calculate the bound

Re: RFR: JDK-8320444: Column drag header is positioned wrong for nested columns [v2]

2023-11-21 Thread Marius Hanl
On Tue, 21 Nov 2023 17:28:26 GMT, Andy Goryachev wrote: >> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TableViewSkinTest.java >> line 225: >> >>> 223: TableColumnHeaderShim.columnReordering(tableColumnHeader, >>> bounds.getMinX() + 20, bounds.getMinY()); >>> 22

Re: RFR: JDK-8320444: Column drag header is positioned wrong for nested columns

2023-11-21 Thread Andy Goryachev
On Mon, 20 Nov 2023 22:24:58 GMT, Marius Hanl wrote: > When a nested column is dragged, the column drag header (blue) is positioned > wrong. > It appears at the very left of the table and not where the column is. > > ![image](https://github.com/openjdk/jfx/assets/66004280/6c2a0f61-f32d-4c38-954

Re: RFR: JDK-8320444: Column drag header is positioned wrong for nested columns

2023-11-21 Thread Andy Goryachev
On Tue, 21 Nov 2023 13:42:05 GMT, Karthik P K wrote: >> When a nested column is dragged, the column drag header (blue) is positioned >> wrong. >> It appears at the very left of the table and not where the column is. >> >> ![image](https://github.com/openjdk/jfx/assets/66004280/6c2a0f61-f32d-4c3

Re: RFR: JDK-8320444: Column drag header is positioned wrong for nested columns

2023-11-21 Thread Karthik P K
On Mon, 20 Nov 2023 22:24:58 GMT, Marius Hanl wrote: > When a nested column is dragged, the column drag header (blue) is positioned > wrong. > It appears at the very left of the table and not where the column is. > > ![image](https://github.com/openjdk/jfx/assets/66004280/6c2a0f61-f32d-4c38-954

RFR: JDK-8320444: Column drag header is positioned wrong for nested columns

2023-11-20 Thread Marius Hanl
When a nested column is dragged, the column drag header (blue) is positioned wrong. It appears at the very left of the table and not where the column is. ![image](https://github.com/openjdk/jfx/assets/66004280/6c2a0f61-f32d-4c38-9549-e2e20f5bd4f8) The fix is to calculate the bound based off the