Re: RFR: JDK-8245919: Region#padding property rendering error [v3]

2023-05-15 Thread Kevin Rushforth
On Mon, 15 May 2023 17:57:21 GMT, Andy Goryachev wrote: >> Even if there is, this still shouln't stop us using new language features, >> should it? Otherwise we can't really use any new feature, as a fix *might* >> be backported. >> On the other hand it is also easy to replace this text block w

Re: RFR: JDK-8245919: Region#padding property rendering error [v3]

2023-05-15 Thread Kevin Rushforth
On Mon, 15 May 2023 17:23:45 GMT, John Hendrikx wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java line >> 1185: >> >>> 1183: if (cssValue != null && >>> "inherit".equals(cssValue.getValue())) { >>> 1184: style = getInheritedStyle(styleable, pr

Re: RFR: JDK-8245919: Region#padding property rendering error [v3]

2023-05-15 Thread Andy Goryachev
On Mon, 15 May 2023 17:55:09 GMT, Marius Hanl wrote: >> modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java >> line 622: >> >>> 620: } >>> 621: """ >>> 622: ); >> >> is there a chance we would backport this fix (to < java15)? > >

Re: RFR: JDK-8245919: Region#padding property rendering error [v3]

2023-05-15 Thread Marius Hanl
On Mon, 15 May 2023 16:44:58 GMT, Andy Goryachev wrote: >> John Hendrikx has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> com

Re: RFR: JDK-8245919: Region#padding property rendering error [v3]

2023-05-15 Thread John Hendrikx
On Mon, 15 May 2023 16:41:33 GMT, Andy Goryachev wrote: >> John Hendrikx has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> com

Re: RFR: JDK-8245919: Region#padding property rendering error [v3]

2023-05-15 Thread Andy Goryachev
On Tue, 18 Apr 2023 12:17:53 GMT, John Hendrikx wrote: >> Fix bug in CSS caching code that could reset values on unrelated nodes. >> >> The bug occurs due to a cache entry being constructed incorrectly when the >> initial node that triggered the cache entry creation has user set values. >> The

Re: RFR: JDK-8245919: Region#padding property rendering error [v3]

2023-05-15 Thread Andy Goryachev
On Sun, 14 May 2023 17:36:12 GMT, Marius Hanl wrote: >> John Hendrikx has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commit

Re: RFR: JDK-8245919: Region#padding property rendering error [v3]

2023-05-14 Thread Marius Hanl
On Tue, 18 Apr 2023 12:17:53 GMT, John Hendrikx wrote: >> Fix bug in CSS caching code that could reset values on unrelated nodes. >> >> The bug occurs due to a cache entry being constructed incorrectly when the >> initial node that triggered the cache entry creation has user set values. >> The

Re: RFR: JDK-8245919: Region#padding property rendering error [v3]

2023-05-14 Thread Marius Hanl
On Tue, 18 Apr 2023 12:17:53 GMT, John Hendrikx wrote: >> Fix bug in CSS caching code that could reset values on unrelated nodes. >> >> The bug occurs due to a cache entry being constructed incorrectly when the >> initial node that triggered the cache entry creation has user set values. >> The

Re: RFR: JDK-8245919: Region#padding property rendering error [v3]

2023-05-05 Thread John Hendrikx
On Tue, 18 Apr 2023 12:17:53 GMT, John Hendrikx wrote: >> Fix bug in CSS caching code that could reset values on unrelated nodes. >> >> The bug occurs due to a cache entry being constructed incorrectly when the >> initial node that triggered the cache entry creation has user set values. >> The

Re: RFR: JDK-8245919: Region#padding property rendering error [v3]

2023-05-04 Thread Michael Strauß
On Tue, 18 Apr 2023 12:17:53 GMT, John Hendrikx wrote: >> Fix bug in CSS caching code that could reset values on unrelated nodes. >> >> The bug occurs due to a cache entry being constructed incorrectly when the >> initial node that triggered the cache entry creation has user set values. >> The

Re: RFR: JDK-8245919: Region#padding property rendering error [v3]

2023-04-18 Thread John Hendrikx
> Fix bug in CSS caching code that could reset values on unrelated nodes. > > The bug occurs due to a cache entry being constructed incorrectly when the > initial node that triggered the cache entry creation has user set values. The > calculated values for properties with a user set value were o