On Tue, 18 Apr 2023 12:17:53 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> Fix bug in CSS caching code that could reset values on unrelated nodes. >> >> The bug occurs due to a cache entry being constructed incorrectly when the >> initial node that triggered the cache entry creation has user set values. >> The calculated values for properties with a user set value were omitted in >> the cache entry, and other nodes that later share the same entry would >> incorrectly assume the omitted property was unstyled and were therefore >> reset to their default values. > > John Hendrikx has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - Merge branch 'openjdk:master' into feature/css-cache-bug > - Fix typo > - Fix bug in CSS caching code that could reset values on unrelated nodes > > The bug occurs due to a cache entry being constructed incorrectly when > the initial node that triggered the cache entry creation has user set > values. The calculated values for properties with a user set value were > omitted in the cache entry, and other nodes that later share the same > entry would incorrectly assume the omitted property was unstyled and > were therefore reset to their default values. Marked as reviewed by mstrauss (Committer). ------------- PR Review: https://git.openjdk.org/jfx/pull/1072#pullrequestreview-1413695522
