Re: RFR: 8343336: Add persistentScrollBars preference [v6]

2024-12-02 Thread Andy Goryachev
On Wed, 27 Nov 2024 00:26:16 GMT, Michael Strauß wrote: >> This PR adds another accessibility preference that is available on all >> supported desktop platforms: >> >> 1. **Windows**: Settings -> Accessibility -> Visual Effects -> Always show >> scroll bars >> 2. **macOS**: System Settings ->

Re: RFR: 8343336: Add persistentScrollBars preference [v6]

2024-11-27 Thread Kevin Rushforth
On Wed, 27 Nov 2024 13:50:11 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/native-glass/gtk/PlatformSupport.cpp line >> 125: >> >>> 123: putBoolean(env, prefs, "GTK.enable_animations", >>> enableAnimations); >>> 124: >>> 125: if (g_object_class_find_property(G

Re: RFR: 8343336: Add persistentScrollBars preference [v6]

2024-11-27 Thread Michael Strauß
On Wed, 27 Nov 2024 13:09:23 GMT, Kevin Rushforth wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> com

Re: RFR: 8343336: Add persistentScrollBars preference [v6]

2024-11-27 Thread Kevin Rushforth
On Wed, 27 Nov 2024 00:26:16 GMT, Michael Strauß wrote: >> This PR adds another accessibility preference that is available on all >> supported desktop platforms: >> >> 1. **Windows**: Settings -> Accessibility -> Visual Effects -> Always show >> scroll bars >> 2. **macOS**: System Settings ->

Re: RFR: 8343336: Add persistentScrollBars preference [v6]

2024-11-26 Thread Michael Strauß
> This PR adds another accessibility preference that is available on all > supported desktop platforms: > > 1. **Windows**: Settings -> Accessibility -> Visual Effects -> Always show > scroll bars > 2. **macOS**: System Settings -> Appearance -> Show scroll bars > 3. **Ubuntu**: Settings -> Acce

Re: RFR: 8343336: Add persistentScrollBars preference [v4]

2024-11-26 Thread Michael Strauß
On Tue, 26 Nov 2024 20:43:20 GMT, Kevin Rushforth wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> co

Re: RFR: 8343336: Add persistentScrollBars preference [v5]

2024-11-26 Thread Michael Strauß
> This PR adds another accessibility preference that is available on all > supported desktop platforms: > > 1. **Windows**: Settings -> Accessibility -> Visual Effects -> Always show > scroll bars > 2. **macOS**: System Settings -> Appearance -> Show scroll bars > 3. **Ubuntu**: Settings -> Acce

Re: RFR: 8343336: Add persistentScrollBars preference [v4]

2024-11-26 Thread Kevin Rushforth
On Fri, 1 Nov 2024 23:39:51 GMT, Michael Strauß wrote: >> This PR adds another accessibility preference that is available on all >> supported desktop platforms: >> >> 1. **Windows**: Settings -> Accessibility -> Visual Effects -> Always show >> scroll bars >> 2. **macOS**: System Settings -> A

Re: RFR: 8343336: Add persistentScrollBars preference [v4]

2024-11-14 Thread Andy Goryachev
On Fri, 1 Nov 2024 23:39:51 GMT, Michael Strauß wrote: >> This PR adds another accessibility preference that is available on all >> supported desktop platforms: >> >> 1. **Windows**: Settings -> Accessibility -> Visual Effects -> Always show >> scroll bars >> 2. **macOS**: System Settings -> A

Re: RFR: 8343336: Add persistentScrollBars preference [v4]

2024-11-13 Thread Andy Goryachev
On Fri, 1 Nov 2024 23:39:51 GMT, Michael Strauß wrote: >> This PR adds another accessibility preference that is available on all >> supported desktop platforms: >> >> 1. **Windows**: Settings -> Accessibility -> Visual Effects -> Always show >> scroll bars >> 2. **macOS**: System Settings -> A

Re: RFR: 8343336: Add persistentScrollBars preference [v4]

2024-11-01 Thread Michael Strauß
> This PR adds another accessibility preference that is available on all > supported desktop platforms: > > 1. **Windows**: Settings -> Accessibility -> Visual Effects -> Always show > scroll bars > 2. **macOS**: System Settings -> Appearance -> Show scroll bars > 3. **Ubuntu**: Settings -> Acce

Re: RFR: 8343336: Add persistentScrollBars preference [v3]

2024-11-01 Thread Michael Strauß
> This PR adds another accessibility preference that is available on all > supported desktop platforms: > > 1. **Windows**: Settings -> Accessibility -> Visual Effects -> Always show > scroll bars > 2. **macOS**: System Settings -> Appearance -> Show scroll bars > 3. **Ubuntu**: Settings -> Acce

Re: RFR: 8343336: Add persistentScrollBars preference [v2]

2024-11-01 Thread Michael Strauß
On Fri, 1 Nov 2024 13:51:19 GMT, Kevin Rushforth wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Change reducedScrollBars to persistentScrollBars > > modules/javafx.graphics/src/main/java/javafx/application/Platf

Re: RFR: 8343336: Add persistentScrollBars preference [v2]

2024-11-01 Thread Kevin Rushforth
On Thu, 31 Oct 2024 20:52:50 GMT, Michael Strauß wrote: >> This PR adds another accessibility preference that is available on all >> supported desktop platforms: >> >> 1. **Windows**: Settings -> Accessibility -> Visual Effects -> Always show >> scroll bars >> 2. **macOS**: System Settings ->

Re: RFR: 8343336: Add persistentScrollBars preference

2024-11-01 Thread Kevin Rushforth
On Thu, 31 Oct 2024 18:16:51 GMT, Michael Strauß wrote: > My thinking is that a particular preference should be useful and almost > universally supported on the desktop platforms to make it into JavaFX API. This seems like the right criteria to me. > The number of preferences we might consider

Re: RFR: 8343336: Add persistentScrollBars preference

2024-11-01 Thread Kevin Rushforth
On Thu, 31 Oct 2024 17:56:07 GMT, Andy Goryachev wrote: >> This PR adds another accessibility preference that is available on all >> supported desktop platforms: >> >> 1. **Windows**: Settings -> Accessibility -> Visual Effects -> Always show >> scroll bars >> 2. **macOS**: System Settings ->

Re: RFR: 8343336: Add persistentScrollBars preference

2024-10-31 Thread Michael Strauß
On Thu, 31 Oct 2024 03:56:30 GMT, Michael Strauß wrote: > This PR adds another accessibility preference that is available on all > supported desktop platforms: > > 1. **Windows**: Settings -> Accessibility -> Visual Effects -> Always show > scroll bars > 2. **macOS**: System Settings -> Appear

Re: RFR: 8343336: Add persistentScrollBars preference [v2]

2024-10-31 Thread Michael Strauß
> This PR adds another accessibility preference that is available on all > supported desktop platforms: > > 1. **Windows**: Settings -> Accessibility -> Visual Effects -> Always show > scroll bars > 2. **macOS**: System Settings -> Appearance -> Show scroll bars > 3. **Ubuntu**: Settings -> Acce