On Wed, 27 Nov 2024 13:50:11 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> modules/javafx.graphics/src/main/native-glass/gtk/PlatformSupport.cpp line
>> 125:
>>
>>> 123: putBoolean(env, prefs, "GTK.enable_animations",
>>> enableAnimations);
>>> 124:
>>> 125: if (g_object_class_find_property(G_OBJECT_GET_CLASS(settings),
>>> "gtk-overlay-scrolling")) {
>>
>> Looks good, presuming that we want the property to be absent on systems that
>> don't support this setting.
>
> Yes, a property that isn't available shouldn't be included in the preferences
> map. We've documented that in `Platform.Preferences`:
>
> * The preferences that are reported by the platform may be dependent on
> the operating system version
> * and its current configuration, so applications should not assume that
> a particular preference is
> * always available.
Yes, so this is fine.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1618#discussion_r1860705373
