On Tue, 25 Mar 2025 21:46:51 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/text/TextRun.java line
>> 45:
>>
>>> 43: int script;
>>> 44: TextSpan span;
>>> 45: com.sun.javafx.scene.text.TextLine line;
>>
>> I recommend an import rather than listi
On Tue, 25 Mar 2025 21:55:54 GMT, Andy Goryachev wrote:
>> Changed the StubTextLayout to use product PrismTextLayout with much
>> simplified glyph layout (via stubbed fonts). The new layout assumes all the
>> glyphs are squares of font size, while the bold type face produces wider
>> glyphs (
On Tue, 25 Mar 2025 21:55:54 GMT, Andy Goryachev wrote:
>> Changed the StubTextLayout to use product PrismTextLayout with much
>> simplified glyph layout (via stubbed fonts). The new layout assumes all the
>> glyphs are squares of font size, while the bold type face produces wider
>> glyphs (
On Tue, 25 Mar 2025 18:36:51 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert "fixed bad merge"
>>
>> This reverts commit 0e9e8ee63895bd1d976398587add5b96958d38aa.
>
> modules/java
On Tue, 25 Mar 2025 21:55:54 GMT, Andy Goryachev wrote:
>> Changed the StubTextLayout to use product PrismTextLayout with much
>> simplified glyph layout (via stubbed fonts). The new layout assumes all the
>> glyphs are squares of font size, while the bold type face produces wider
>> glyphs (
On Tue, 25 Mar 2025 17:43:43 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert "fixed bad merge"
>>
>> This reverts commit 0e9e8ee63895bd1d976398587add5b96958d38aa.
>
> modules/java
On Tue, 25 Mar 2025 21:41:14 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ListViewTest.java
>> line 100:
>>
>>> 98: import test.com.sun.javafx.scene.control.test.RT_22463_Person;
>>> 99:
>>> 100: /**
>>
>> Minor: We don't typically use javadoc-
> Changed the StubTextLayout to use product PrismTextLayout with much
> simplified glyph layout (via stubbed fonts). The new layout assumes all the
> glyphs are squares of font size, while the bold type face produces wider
> glyphs (by 1 pixel). The default font size has changed from 10 to 12
On Thu, 6 Mar 2025 16:21:52 GMT, Andy Goryachev wrote:
>> Changed the StubTextLayout to use product PrismTextLayout with much
>> simplified glyph layout (via stubbed fonts). The new layout assumes all the
>> glyphs are squares of font size, while the bold type face produces wider
>> glyphs (b
> Changed the StubTextLayout to use product PrismTextLayout with much
> simplified glyph layout (via stubbed fonts). The new layout assumes all the
> glyphs are squares of font size, while the bold type face produces wider
> glyphs (by 1 pixel). The default font size has changed from 10 to 12
On Thu, 6 Mar 2025 16:21:52 GMT, Andy Goryachev wrote:
>> Changed the StubTextLayout to use product PrismTextLayout with much
>> simplified glyph layout (via stubbed fonts). The new layout assumes all the
>> glyphs are squares of font size, while the bold type face produces wider
>> glyphs (b
On Tue, 4 Feb 2025 08:53:31 GMT, Marius Hanl wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 19 additional
>> commits s
> Changed the StubTextLayout to use product PrismTextLayout with much
> simplified glyph layout (via stubbed fonts). The new layout assumes all the
> glyphs are squares of font size, while the bold type face produces wider
> glyphs (by 1 pixel). The default font size has changed from 10 to 12
> Changed the StubTextLayout to use product PrismTextLayout with much
> simplified glyph layout (via stubbed fonts). The new layout assumes all the
> glyphs are squares of font size, while the bold type face produces wider
> glyphs (by 1 pixel). The default font size has changed from 10 to 12
On Wed, 5 Mar 2025 15:54:49 GMT, Andy Goryachev wrote:
>> Changed the StubTextLayout to use product PrismTextLayout with much
>> simplified glyph layout (via stubbed fonts). The new layout assumes all the
>> glyphs are squares of font size, while the bold type face produces wider
>> glyphs (b
> Changed the StubTextLayout to use product PrismTextLayout with much
> simplified glyph layout (via stubbed fonts). The new layout assumes all the
> glyphs are squares of font size, while the bold type face produces wider
> glyphs (by 1 pixel). The default font size has changed from 10 to 12
On Wed, 26 Feb 2025 22:00:47 GMT, Andy Goryachev wrote:
>> Changed the StubTextLayout to use product PrismTextLayout with much
>> simplified glyph layout (via stubbed fonts). The new layout assumes all the
>> glyphs are squares of font size, while the bold type face produces wider
>> glyphs (
> Changed the StubTextLayout to use product PrismTextLayout with much
> simplified glyph layout (via stubbed fonts). The new layout assumes all the
> glyphs are squares of font size, while the bold type face produces wider
> glyphs (by 1 pixel). The default font size has changed from 10 to 12
On Tue, 4 Feb 2025 08:50:43 GMT, Marius Hanl wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 19 additional
>> commits s
> Changed the StubTextLayout to use product PrismTextLayout with much
> simplified glyph layout (via stubbed fonts). The new layout assumes all the
> glyphs are squares of font size, while the bold type face produces wider
> glyphs (by 1 pixel). The default font size has changed from 10 to 12
On Tue, 4 Feb 2025 08:53:31 GMT, Marius Hanl wrote:
> `S`, `M` or `L` as variable names (minor)
the meaning should be obvious from the context (small, medium, large) and I
don't want code like this to take two pages:
testScrollTo(360, 1, new Integer[] { S, S, S, S, S, S, S, S, S, S, S, S, S, S
On Wed, 29 Jan 2025 19:01:40 GMT, Andy Goryachev wrote:
>> Changed the StubTextLayout to use product PrismTextLayout with much
>> simplified glyph layout (via stubbed fonts). The new layout assumes all the
>> glyphs are squares of font size, while the bold type face produces wider
>> glyphs (
On Wed, 29 Jan 2025 19:01:40 GMT, Andy Goryachev wrote:
>> Changed the StubTextLayout to use product PrismTextLayout with much
>> simplified glyph layout (via stubbed fonts). The new layout assumes all the
>> glyphs are squares of font size, while the bold type face produces wider
>> glyphs (
> Changed the StubTextLayout to use product PrismTextLayout with much
> simplified glyph layout (via stubbed fonts). The new layout assumes all the
> glyphs are squares of font size, while the bold type face produces wider
> glyphs (by 1 pixel). The default font size has changed from 10 to 12
On Fri, 20 Dec 2024 22:23:11 GMT, Andy Goryachev wrote:
> Changed the StubTextLayout to use product PrismTextLayout with much
> simplified glyph layout (via stubbed fonts). The new layout assumes all the
> glyphs are squares of font size, while the bold type face produces wider
> glyphs (by 1
On Fri, 20 Dec 2024 22:23:11 GMT, Andy Goryachev wrote:
> Changed the StubTextLayout to use product PrismTextLayout with much
> simplified glyph layout (via stubbed fonts). The new layout assumes all the
> glyphs are squares of font size, while the bold type face produces wider
> glyphs (by 1
On Mon, 27 Jan 2025 21:15:44 GMT, Kevin Rushforth wrote:
> This pull request has been inactive for more than 4 weeks
I doubt that.
-
PR Comment: https://git.openjdk.org/jfx/pull/1667#issuecomment-2616913729
Changed the StubTextLayout to use product PrismTextLayout with much simplified
glyph layout (via stubbed fonts). The new layout assumes all the glyphs are
squares of font size, while the bold type face produces wider glyphs (by 1
pixel). The default font size has changed from 10 to 12 to make
28 matches
Mail list logo