Re: [jfx23] RFR: 8339247: Create release notes for JavaFX 23

2025-03-03 Thread Kevin Rushforth
On Sat, 1 Mar 2025 04:02:55 GMT, Abhinay Agarwal wrote: >> Backport the JavaFX 23 release notes to the `jfx23` branch. Note that we >> will _not_ trigger a respin of JavaFX 23 as a result of this. > > doc-files/release-notes-23.md line 11: > >> 9: ## Important Changes >> 10: >> 11: ### JavaFX

Re: [jfx23] RFR: 8339247: Create release notes for JavaFX 23

2025-03-03 Thread Abhinay Agarwal
On Mon, 3 Mar 2025 21:10:23 GMT, Kevin Rushforth wrote: > This is the PR for the JavaFX 23 release notes My bad. > See [this section of the OpenJDK Developers > Guide](https://openjdk.org/guide/#general-conventions-for-release-notes). Thank you for the link. - PR Review Comment:

Re: [jfx23] RFR: 8339247: Create release notes for JavaFX 23

2025-02-28 Thread Abhinay Agarwal
On Thu, 12 Sep 2024 11:43:14 GMT, Kevin Rushforth wrote: > Backport the JavaFX 23 release notes to the `jfx23` branch. Note that we will > _not_ trigger a respin of JavaFX 23 as a result of this. doc-files/release-notes-23.md line 11: > 9: ## Important Changes > 10: > 11: ### JavaFX 23 Requir

Re: [jfx23] RFR: 8339247: Create release notes for JavaFX 23

2024-09-12 Thread Johan Vos
On Thu, 12 Sep 2024 11:43:14 GMT, Kevin Rushforth wrote: > Backport the JavaFX 23 release notes to the `jfx23` branch. Note that we will > _not_ trigger a respin of JavaFX 23 as a result of this. Marked as reviewed by jvos (Reviewer). - PR Review: https://git.openjdk.org/jfx/pull/

Re: [jfx23] RFR: 8339247: Create release notes for JavaFX 23

2024-09-12 Thread Kevin Rushforth
On Thu, 12 Sep 2024 11:43:14 GMT, Kevin Rushforth wrote: > Backport the JavaFX 23 release notes to the `jfx23` branch. Note that we will > _not_ trigger a respin of JavaFX 23 as a result of this. @andy-goryachev-oracle @arapte @johanvos Can I get a quick review from one of you for this clean b

[jfx23] RFR: 8339247: Create release notes for JavaFX 23

2024-09-12 Thread Kevin Rushforth
Backport the JavaFX 23 release notes to the `jfx23` branch. Note that we will _not_ trigger a respin of JavaFX 23 as a result of this. - Commit messages: - Backport 639f138380a4091befa3046f7211aab77f8d77dd Changes: https://git.openjdk.org/jfx/pull/1563/files Webrev: https://webre

Re: RFR: 8339247: Create release notes for JavaFX 23 [v2]

2024-09-11 Thread Kevin Rushforth
On Wed, 4 Sep 2024 14:38:00 GMT, Kevin Rushforth wrote: >> This PR adds the release notes for the JavaFX 23 release. This will first go >> into `master`, and then be backported to the `jfx23` branch so it will be >> available in that branch when JavaFX 23 is published (and from there also >> s

Re: RFR: 8339247: Create release notes for JavaFX 23 [v2]

2024-09-06 Thread Kevin Rushforth
On Wed, 4 Sep 2024 14:40:45 GMT, Andy Goryachev wrote: > Just a suggestion - sharing some tricks of writing the .md format: > > It might be easier to review if the pipe characters in the table were > aligned, and have at least one space separation from the previous cell's > text. This makes it

Re: RFR: 8339247: Create release notes for JavaFX 23 [v2]

2024-09-04 Thread Kevin Rushforth
On Wed, 4 Sep 2024 15:47:39 GMT, Nir Lisker wrote: > I forgot I noted for myself some docs typos for this version. Obviously not > critical to get them into 23, but if there's time before this is merged > (should be until September 9th), I can create a PR quickly along the usual > lines that w

Re: RFR: 8339247: Create release notes for JavaFX 23 [v2]

2024-09-04 Thread Nir Lisker
On Wed, 4 Sep 2024 14:38:00 GMT, Kevin Rushforth wrote: >> This PR adds the release notes for the JavaFX 23 release. This will first go >> into `master`, and then be backported to the `jfx23` branch so it will be >> available in that branch when JavaFX 23 is published (and from there also >> s

Re: RFR: 8339247: Create release notes for JavaFX 23 [v2]

2024-09-04 Thread Andy Goryachev
On Wed, 4 Sep 2024 14:38:00 GMT, Kevin Rushforth wrote: >> This PR adds the release notes for the JavaFX 23 release. This will first go >> into `master`, and then be backported to the `jfx23` branch so it will be >> available in that branch when JavaFX 23 is published (and from there also >> s

Re: RFR: 8339247: Create release notes for JavaFX 23

2024-09-04 Thread Kevin Rushforth
On Wed, 4 Sep 2024 13:18:21 GMT, Nir Lisker wrote: > > Should I split the "Enhancements" section into two groups as shown in the > > PR Description, or leave it as a single group? ... > I think the split should be kept. Done. > Just noticed: we might want to title case "Issue key" in both tabl

Re: RFR: 8339247: Create release notes for JavaFX 23 [v2]

2024-09-04 Thread Kevin Rushforth
> This PR adds the release notes for the JavaFX 23 release. This will first go > into `master`, and then be backported to the `jfx23` branch so it will be > available in that branch when JavaFX 23 is published (and from there also > synced into the `jfx23u` repo). > > The following filter was u

Re: RFR: 8339247: Create release notes for JavaFX 23

2024-09-04 Thread Andy Goryachev
On Fri, 30 Aug 2024 12:47:38 GMT, Kevin Rushforth wrote: > This PR adds the release notes for the JavaFX 23 release. This will first go > into `master`, and then be backported to the `jfx23` branch so it will be > available in that branch when JavaFX 23 is published (and from there also > sync

Re: RFR: 8339247: Create release notes for JavaFX 23

2024-09-04 Thread Abhinay Agarwal
On Wed, 4 Sep 2024 06:16:24 GMT, Abhinay Agarwal wrote: >> This PR adds the release notes for the JavaFX 23 release. This will first go >> into `master`, and then be backported to the `jfx23` branch so it will be >> available in that branch when JavaFX 23 is published (and from there also >> s

Re: RFR: 8339247: Create release notes for JavaFX 23

2024-09-04 Thread Nir Lisker
On Wed, 4 Sep 2024 11:42:47 GMT, Kevin Rushforth wrote: > Should I split the "Enhancements" section into two groups as shown in the PR > Description, or leave it as a single group? @abhinayagarwal Do you write the highlights page https://openjfx.io/highlights/22/? Will the same split be done t

Re: RFR: 8339247: Create release notes for JavaFX 23

2024-09-04 Thread Kevin Rushforth
On Wed, 4 Sep 2024 06:16:24 GMT, Abhinay Agarwal wrote: > The current separation looks good to me too. A question then for both you and @nlisker : Should I split the "Enhancements" section into two groups as shown in the PR Description, or leave it as a single group? > I have a question relat

Re: RFR: 8339247: Create release notes for JavaFX 23

2024-09-03 Thread Abhinay Agarwal
On Fri, 30 Aug 2024 12:47:38 GMT, Kevin Rushforth wrote: > This PR adds the release notes for the JavaFX 23 release. This will first go > into `master`, and then be backported to the `jfx23` branch so it will be > available in that branch when JavaFX 23 is published (and from there also > sync

Re: RFR: 8339247: Create release notes for JavaFX 23

2024-09-03 Thread Andy Goryachev
On Fri, 30 Aug 2024 12:47:38 GMT, Kevin Rushforth wrote: > This PR adds the release notes for the JavaFX 23 release. This will first go > into `master`, and then be backported to the `jfx23` branch so it will be > available in that branch when JavaFX 23 is published (and from there also > sync

Re: RFR: 8339247: Create release notes for JavaFX 23

2024-08-30 Thread Nir Lisker
On Fri, 30 Aug 2024 12:47:38 GMT, Kevin Rushforth wrote: > This PR adds the release notes for the JavaFX 23 release. This will first go > into `master`, and then be backported to the `jfx23` branch so it will be > available in that branch when JavaFX 23 is published (and from there also > sync

Re: RFR: 8339247: Create release notes for JavaFX 23

2024-08-30 Thread Kevin Rushforth
On Fri, 30 Aug 2024 12:47:38 GMT, Kevin Rushforth wrote: > This PR adds the release notes for the JavaFX 23 release. This will first go > into `master`, and then be backported to the `jfx23` branch so it will be > available in that branch when JavaFX 23 is published (and from there also > sync

Re: RFR: 8339247: Create release notes for JavaFX 23

2024-08-30 Thread Kevin Rushforth
On Fri, 30 Aug 2024 12:47:38 GMT, Kevin Rushforth wrote: > This PR adds the release notes for the JavaFX 23 release. This will first go > into `master`, and then be backported to the `jfx23` branch so it will be > available in that branch when JavaFX 23 is published (and from there also > sync

RFR: 8339247: Create release notes for JavaFX 23

2024-08-30 Thread Kevin Rushforth
This PR adds the release notes for the JavaFX 23 release. This will first go into `master`, and then be backported to the `jfx23` branch so it will be available in that branch when JavaFX 23 is published (and from there also synced into the `jfx23u` repo). The following filter was used to produ