Re: [jfx23u] RFR: 8338886: JavaFX debug builds fail on macOS

2024-08-28 Thread Andy Goryachev
On Wed, 28 Aug 2024 14:10:04 GMT, Jay Bhaskar wrote: > A clean backport to jfx23u. The fix is for a build error , failing to build > on mac on debug mode. clean backport - Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx23u/pull/16#pullrequestrevie

[jfx23u] RFR: 8338886: JavaFX debug builds fail on macOS

2024-08-28 Thread Jay Bhaskar
A clean backport to jfx23u. The fix is for a build error , failing to build on mac on debug mode. - Commit messages: - Backport 48497168892f5625f77936eccf19e836a6c1971e Changes: https://git.openjdk.org/jfx23u/pull/16/files Webrev: https://webrevs.openjdk.org/?repo=jfx23u&pr=16&ra

Re: RFR: 8338886: JavaFX debug builds fail on macOS

2024-08-23 Thread Kevin Rushforth
On Fri, 23 Aug 2024 05:21:21 GMT, Jay Bhaskar wrote: > Issue: ASSERT Statement: The ASSERT macro or function seems to be used to > check if a condition involving ExceptionCode is true, but it's failing to > compile. > Solution: The expression for ASSERT should be checked with type. This is a t

RFR: 8338886: JavaFX debug builds fail on macOS

2024-08-22 Thread Jay Bhaskar
Issue: ASSERT Statement: The ASSERT macro or function seems to be used to check if a condition involving ExceptionCode is true, but it's failing to compile. Solution: The expression for ASSERT should be checked with type. - Commit messages: - 8338886: JavaFX debug builds fail on mac