On Fri, 23 Aug 2024 05:21:21 GMT, Jay Bhaskar <jbhas...@openjdk.org> wrote:
> Issue: ASSERT Statement: The ASSERT macro or function seems to be used to > check if a condition involving ExceptionCode is true, but it's failing to > compile. > Solution: The expression for ASSERT should be checked with type. This is a trivial fix that only affects a debug build. It does not affect production builds or ordinary developer builds. A single reviewer is sufficient. The fix looks good. I can now build in debug mode using: `gradle -PCONF=DebugNative` Running the debug build on my M1 Mac and loading a non-trivial web page crashes after a short time with a call to "abort()", but that's unrelated to this build failure and should be handled as a follow-on bug. ------------- Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1544#pullrequestreview-2257612449
