On Tue, 6 Aug 2024 13:03:15 GMT, Thiago Milczarek Sayao
wrote:
> Is it ok to integrate? I got the e-mail saying so, but not really sure.
Yes. There are two approving reviews, and no outstanding comments or questions.
-
PR Comment: https://git.openjdk.org/jfx/pull/1460#issuecomment
On Mon, 29 Jul 2024 14:29:17 GMT, Thiago Milczarek Sayao
wrote:
>> Specific to KDE, in the case of the example provided, when an MODAL window
>> pops, it calls `set_enabled` `false` on the child (or all other windows if
>> APPLICATION_MODAL) which causes it to update the window constraints. Wh
On Mon, 29 Jul 2024 14:29:17 GMT, Thiago Milczarek Sayao
wrote:
>> Specific to KDE, in the case of the example provided, when an MODAL window
>> pops, it calls `set_enabled` `false` on the child (or all other windows if
>> APPLICATION_MODAL) which causes it to update the window constraints. Wh
On Mon, 29 Jul 2024 14:29:17 GMT, Thiago Milczarek Sayao
wrote:
>> Specific to KDE, in the case of the example provided, when an MODAL window
>> pops, it calls `set_enabled` `false` on the child (or all other windows if
>> APPLICATION_MODAL) which causes it to update the window constraints. Wh
On Mon, 29 Jul 2024 14:29:17 GMT, Thiago Milczarek Sayao
wrote:
>> Specific to KDE, in the case of the example provided, when an MODAL window
>> pops, it calls `set_enabled` `false` on the child (or all other windows if
>> APPLICATION_MODAL) which causes it to update the window constraints. Wh
On Mon, 17 Jun 2024 23:34:06 GMT, Andy Goryachev wrote:
> I've tested a bit more on linux mint (not a KDE desktop), see no ill effects.
>
> There were a couple of warnings opening modal and regular windows, but the
> same warnings are present in the master branch.
>
> For completeness sake, he
On Mon, 29 Jul 2024 14:29:17 GMT, Thiago Milczarek Sayao
wrote:
>> Specific to KDE, in the case of the example provided, when an MODAL window
>> pops, it calls `set_enabled` `false` on the child (or all other windows if
>> APPLICATION_MODAL) which causes it to update the window constraints. Wh
> This fixes two bugs appointed on the JBS issue:
>
> 1) Sometimes window was moving to the top left corner - seems to be a bug
> somewhere in `gdk_window_get_origin` when used before map (a X concept when
> the window appears). The change is to ignore the configure events (happens
> when locat
> This fixes two bugs appointed on the JBS issue:
>
> 1) Sometimes window was moving to the top left corner - seems to be a bug
> somewhere in `gdk_window_get_origin` when used before map (a X concept when
> the window appears). The change is to ignore the configure events (happens
> when locat
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao
wrote:
>> This fixes two bugs appointed on the JBS issue:
>>
>> 1) Sometimes window was moving to the top left corner - seems to be a bug
>> somewhere in `gdk_window_get_origin` when used before map (a X concept when
>> the window appea
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao
wrote:
>> This fixes two bugs appointed on the JBS issue:
>>
>> 1) Sometimes window was moving to the top left corner - seems to be a bug
>> somewhere in `gdk_window_get_origin` when used before map (a X concept when
>> the window appea
On Mon, 17 Jun 2024 18:54:15 GMT, Andy Goryachev wrote:
> Initial comments:
>
> 1. the description says this fixes two issues. do we have two JBS tickets?
> if so, please add the other ticket to this PR
> 2. the description in JDK-833 is insufficient: missing steps to
> reproduce, expect
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao
wrote:
>> This fixes two bugs appointed on the JBS issue:
>>
>> 1) Sometimes window was moving to the top left corner - seems to be a bug
>> somewhere in `gdk_window_get_origin` when used before map (a X concept when
>> the window appea
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao
wrote:
>> This fixes two bugs appointed on the JBS issue:
>>
>> 1) Sometimes window was moving to the top left corner - seems to be a bug
>> somewhere in `gdk_window_get_origin` when used before map (a X concept when
>> the window appea
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao
wrote:
>> This fixes two bugs appointed on the JBS issue:
>>
>> 1) Sometimes window was moving to the top left corner - seems to be a bug
>> somewhere in `gdk_window_get_origin` when used before map (a X concept when
>> the window appea
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao
wrote:
>> This fixes two bugs appointed on the JBS issue:
>>
>> 1) Sometimes window was moving to the top left corner - seems to be a bug
>> somewhere in `gdk_window_get_origin` when used before map (a X concept when
>> the window appea
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao
wrote:
>> This fixes two bugs appointed on the JBS issue:
>>
>> 1) Sometimes window was moving to the top left corner - seems to be a bug
>> somewhere in `gdk_window_get_origin` when used before map (a X concept when
>> the window appea
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao
wrote:
>> This fixes two bugs appointed on the JBS issue:
>>
>> 1) Sometimes window was moving to the top left corner - seems to be a bug
>> somewhere in `gdk_window_get_origin` when used before map (a X concept when
>> the window appea
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao
wrote:
>> This fixes two bugs appointed on the JBS issue:
>>
>> 1) Sometimes window was moving to the top left corner - seems to be a bug
>> somewhere in `gdk_window_get_origin` when used before map (a X concept when
>> the window appea
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao
wrote:
>> This fixes two bugs appointed on the JBS issue:
>>
>> 1) Sometimes window was moving to the top left corner - seems to be a bug
>> somewhere in `gdk_window_get_origin` when used before map (a X concept when
>> the window appea
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao
wrote:
>> This fixes two bugs appointed on the JBS issue:
>>
>> 1) Sometimes window was moving to the top left corner - seems to be a bug
>> somewhere in `gdk_window_get_origin` when used before map (a X concept when
>> the window appea
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao
wrote:
>> This fixes two bugs appointed on the JBS issue:
>>
>> 1) Sometimes window was moving to the top left corner - seems to be a bug
>> somewhere in `gdk_window_get_origin` when used before map (a X concept when
>> the window appea
On Thu, 23 May 2024 10:48:08 GMT, Jose Pereda wrote:
>> The linux build seems to be failing because the lack of gcc-13 package.
>
> @tsayao the Ubuntu runner uses now 24.0.4. Your branch just needs to be
> synced with head.
@jperedadnr Thanks.
@karthikpandelu I tested the sample with the Debia
On Thu, 23 May 2024 10:37:09 GMT, Thiago Milczarek Sayao
wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Should still report location
>
> The linux build seems to be failing because the lack of gcc-13 pa
> This fixes two bugs appointed on the JBS issue:
>
> 1) Sometimes window was moving to the top left corner - seems to be a bug
> somewhere in `gdk_window_get_origin` when used before map (a X concept when
> the window appears). The change is to ignore the configure events (happens
> when locat
On Thu, 23 May 2024 10:29:33 GMT, Thiago Milczarek Sayao
wrote:
>> This fixes two bugs appointed on the JBS issue:
>>
>> 1) Sometimes window was moving to the top left corner - seems to be a bug
>> somewhere in `gdk_window_get_origin` when used before map (a X concept when
>> the window appea
On Thu, 23 May 2024 10:29:33 GMT, Thiago Milczarek Sayao
wrote:
>> This fixes two bugs appointed on the JBS issue:
>>
>> 1) Sometimes window was moving to the top left corner - seems to be a bug
>> somewhere in `gdk_window_get_origin` when used before map (a X concept when
>> the window appea
> This fixes two bugs appointed on the JBS issue:
>
> 1) Sometimes window was moving to the top left corner - seems to be a bug
> somewhere in `gdk_window_get_origin` when used before map (a X concept when
> the window appears). The change is to ignore the configure events (happens
> when locat
On Wed, 22 May 2024 21:28:47 GMT, Thiago Milczarek Sayao
wrote:
> This fixes two bugs appointed on the JBS issue:
>
> 1) Sometimes window was moving to the top left corner - seems to be a bug
> somewhere in `gdk_window_get_origin` when used before map (a X concept when
> the window appears).
This fixes two bugs appointed on the JBS issue:
1) Sometimes window was moving to the top left corner - seems to be a bug
somewhere in `gdk_window_get_origin` when used before map (a X concept when the
window appears). The change is to ignore the configure events (happens when
location or size
30 matches
Mail list logo
