On Mon, 28 Jul 2025 15:13:07 GMT, Johan Vos wrote:
>> After spending a year in the sandbox repository, the Headless Platform is
>> now ready to be reviewed in the main repository.
>>
>> ### the Headless Platform
>> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
>>
On Fri, 25 Jul 2025 13:42:28 GMT, Kevin Rushforth wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add copyright sections
>
> I'll review the code soon. I ran a full set of tests, excluding the robot
> tests, and see
On Mon, 28 Jul 2025 15:13:07 GMT, Johan Vos wrote:
>> After spending a year in the sandbox repository, the Headless Platform is
>> now ready to be reviewed in the main repository.
>>
>> ### the Headless Platform
>> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
>>
On Mon, 28 Jul 2025 15:13:07 GMT, Johan Vos wrote:
>> After spending a year in the sandbox repository, the Headless Platform is
>> now ready to be reviewed in the main repository.
>>
>> ### the Headless Platform
>> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
>>
> After spending a year in the sandbox repository, the Headless Platform is now
> ready to be reviewed in the main repository.
>
> ### the Headless Platform
> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
> the second-level Monocle-Headless subplatform, that is par
On Mon, 28 Jul 2025 11:38:26 GMT, Johan Vos wrote:
>> After spending a year in the sandbox repository, the Headless Platform is
>> now ready to be reviewed in the main repository.
>>
>> ### the Headless Platform
>> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
>>
On Mon, 28 Jul 2025 11:38:26 GMT, Johan Vos wrote:
>> After spending a year in the sandbox repository, the Headless Platform is
>> now ready to be reviewed in the main repository.
>>
>> ### the Headless Platform
>> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
>>
> After spending a year in the sandbox repository, the Headless Platform is now
> ready to be reviewed in the main repository.
>
> ### the Headless Platform
> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
> the second-level Monocle-Headless subplatform, that is par
> After spending a year in the sandbox repository, the Headless Platform is now
> ready to be reviewed in the main repository.
>
> ### the Headless Platform
> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
> the second-level Monocle-Headless subplatform, that is par
On Tue, 22 Jul 2025 07:09:58 GMT, Johan Vos wrote:
>> After spending a year in the sandbox repository, the Headless Platform is
>> now ready to be reviewed in the main repository.
>>
>> ### the Headless Platform
>> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
>>
On Mon, 7 Jul 2025 09:15:47 GMT, Johan Vos wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessRobot.java
>> line 231:
>>
>>> 229: if (windows.isEmpty()) return null;
>>> 230: if (windows.size() == 1) return (HeadlessWindow)windows.get(0);
>>> 231:
On Tue, 22 Jul 2025 07:09:58 GMT, Johan Vos wrote:
>> After spending a year in the sandbox repository, the Headless Platform is
>> now ready to be reviewed in the main repository.
>>
>> ### the Headless Platform
>> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
>>
On Fri, 18 Jul 2025 19:26:10 GMT, Andy Goryachev wrote:
> > Do you refer to the Node.snapshot()?
>
> In my case, it was Scene::snapshot(), but basically the question is where the
> screen size has any effect? Robot?
>
> It does not seem to impact Scene::snapshot.
The screen size is not releva
> After spending a year in the sandbox repository, the Headless Platform is now
> ready to be reviewed in the main repository.
>
> ### the Headless Platform
> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
> the second-level Monocle-Headless subplatform, that is par
On Fri, 18 Jul 2025 07:34:01 GMT, Johan Vos wrote:
> Do you refer to the Node.snapshot()?
In my case, it was Scene::snapshot(), but basically the question is where the
screen size has any effect? Robot?
It does not seem to impact Scene::snapshot.
(I've used the standalone Monkey Tester wit
On Tue, 15 Jul 2025 01:11:14 GMT, Kevin Rushforth wrote:
> Even if this remains a testing feature, how should it eventually be
> configured? Using system properties? Some sort of config file? Something else?
This was discussed in a number of comments as well, and the suggested approach
is to l
On Wed, 16 Jul 2025 01:56:21 GMT, John Hendrikx wrote:
> > > The first question is: Does this have any use case beyond testing?
> >
> >
> > Good question, and the answer is "Yes, absolutely". One of the main drivers
> > for this was a project where PDF prints need to be generated server-side,
> After spending a year in the sandbox repository, the Headless Platform is now
> ready to be reviewed in the main repository.
>
> ### the Headless Platform
> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
> the second-level Monocle-Headless subplatform, that is par
On Mon, 14 Jul 2025 22:17:56 GMT, Kevin Rushforth wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Specify A as a double.
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessApplication.java
>
On Fri, 27 Jun 2025 20:38:56 GMT, Andy Goryachev wrote:
> Question: While the screen size is limited in this version to 1000x1000, the
> size of the snapshot exceeds that. Is that expected?
Good question.
Do you refer to the Node.snapshot()?
The definition of "screen size" is a bit vague on hea
On Fri, 27 Jun 2025 19:12:32 GMT, Andy Goryachev wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Process reviewer comments
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessRobot.java
> line
On Fri, 27 Jun 2025 19:08:48 GMT, Andy Goryachev wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Process reviewer comments
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessRobot.java
> line
On Tue, 15 Jul 2025 11:32:28 GMT, Johan Vos wrote:
> > The first question is: Does this have any use case beyond testing?
>
> Good question, and the answer is "Yes, absolutely". One of the main drivers
> for this was a project where PDF prints need to be generated server-side,
> starting from
On Tue, 15 Jul 2025 01:11:14 GMT, Kevin Rushforth wrote:
> The first question is: Does this have any use case beyond testing?
Good question, and the answer is "Yes, absolutely". One of the main drivers for
this was a project where PDF prints need to be generated server-side, starting
from `Nod
On Mon, 7 Jul 2025 17:56:06 GMT, Johan Vos wrote:
>> After spending a year in the sandbox repository, the Headless Platform is
>> now ready to be reviewed in the main repository.
>>
>> ### the Headless Platform
>> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
>>
On Mon, 7 Jul 2025 17:15:12 GMT, Jose Pereda wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Process more reviewer comments
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessWindow.java
> li
> After spending a year in the sandbox repository, the Headless Platform is now
> ready to be reviewed in the main repository.
>
> ### the Headless Platform
> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
> the second-level Monocle-Headless subplatform, that is par
On Mon, 7 Jul 2025 09:29:22 GMT, Johan Vos wrote:
>> After spending a year in the sandbox repository, the Headless Platform is
>> now ready to be reviewed in the main repository.
>>
>> ### the Headless Platform
>> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
>>
On Fri, 27 Jun 2025 20:24:57 GMT, Andy Goryachev wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Process reviewer comments
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/NestedRunnableProcessor.ja
On Mon, 7 Jul 2025 14:17:37 GMT, Jose Pereda wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Process more reviewer comments
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessRobot.java
> lin
> After spending a year in the sandbox repository, the Headless Platform is now
> ready to be reviewed in the main repository.
>
> ### the Headless Platform
> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
> the second-level Monocle-Headless subplatform, that is par
On Mon, 7 Jul 2025 09:29:22 GMT, Johan Vos wrote:
>> After spending a year in the sandbox repository, the Headless Platform is
>> now ready to be reviewed in the main repository.
>>
>> ### the Headless Platform
>> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
>>
On Fri, 27 Jun 2025 20:19:24 GMT, Andy Goryachev wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Process reviewer comments
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessWindow.java
> lin
> After spending a year in the sandbox repository, the Headless Platform is now
> ready to be reviewed in the main repository.
>
> ### the Headless Platform
> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
> the second-level Monocle-Headless subplatform, that is par
On Fri, 27 Jun 2025 20:00:48 GMT, Andy Goryachev wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Process reviewer comments
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessWindow.java
> lin
On Thu, 19 Jun 2025 22:45:45 GMT, Michael Strauß wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix missing ;
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/NestedRunnableProcessor.java
> line 2
On Fri, 27 Jun 2025 19:31:43 GMT, Andy Goryachev wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Process reviewer comments
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessRobot.java
> line
On Fri, 27 Jun 2025 16:54:39 GMT, Andy Goryachev wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Process reviewer comments
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessApplication.java
>
> After spending a year in the sandbox repository, the Headless Platform is now
> ready to be reviewed in the main repository.
>
> ### the Headless Platform
> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
> the second-level Monocle-Headless subplatform, that is par
On Fri, 27 Jun 2025 19:59:16 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessView.java
>> line 16:
>>
>>> 14: private Pixels pixels;
>>> 15:
>>> 16: private boolean imeEnabled;
>>
>> The following fields are not read, but only assi
On Thu, 19 Jun 2025 22:37:11 GMT, Michael Strauß wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix missing ;
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessApplication.java
> line 23:
>
On Mon, 7 Jul 2025 07:34:14 GMT, Johan Vos wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessWindow.java
>> line 36:
>>
>>> 34: private float alpha;
>>> 35: private Pixels icon;
>>> 36: private Cursor cursor;
>>
>> The following fields are never used
On Thu, 19 Jun 2025 22:13:09 GMT, Michael Strauß wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix missing ;
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessRobot.java
> line 293:
>
>>
> After spending a year in the sandbox repository, the Headless Platform is now
> ready to be reviewed in the main repository.
>
> ### the Headless Platform
> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
> the second-level Monocle-Headless subplatform, that is par
On Thu, 19 Jun 2025 22:33:10 GMT, Michael Strauß wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix missing ;
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessWindow.java
> line 36:
>
>>
On Fri, 27 Jun 2025 20:15:52 GMT, Andy Goryachev wrote:
>> There was a failing test, so it turns out there is an implicit contract that
>> even if a resize is requested without different w/h parameters, at least the
>> even should still be generated.
>
> should we either add a comment or clean
On Mon, 23 Jun 2025 08:26:30 GMT, Johan Vos wrote:
>> After spending a year in the sandbox repository, the Headless Platform is
>> now ready to be reviewed in the main repository.
>>
>> ### the Headless Platform
>> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
>>
On Mon, 23 Jun 2025 07:43:39 GMT, Johan Vos wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessWindow.java
>> line 294:
>>
>>> 292: private void notifyResizeAndMove(int x, int y, int width, int
>>> height) {
>>> 293: HeadlessView view = (HeadlessView)
On Thu, 19 Jun 2025 22:42:38 GMT, Michael Strauß wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix missing ;
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessView.java
> line 16:
>
>> 14
On Mon, 23 Jun 2025 08:26:30 GMT, Johan Vos wrote:
>> After spending a year in the sandbox repository, the Headless Platform is
>> now ready to be reviewed in the main repository.
>>
>> ### the Headless Platform
>> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
>>
On Thu, 26 Jun 2025 21:02:26 GMT, Andy Goryachev wrote:
>> This is a good question, and I believe it is part of a broader discussion.
>> There are a number of places (e.g. here) where I use hardcoded, default
>> values which should be fine for most usecases I'm aware of. However, I
>> believe
On Thu, 26 Jun 2025 20:35:32 GMT, Johan Vos wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessApplication.java
>> line 138:
>>
>>> 136: @Override
>>> 137: protected Screen[] staticScreen_getScreens() {
>>> 138: final int screenWidth = 1000;
>>
>>
On Tue, 24 Jun 2025 16:38:48 GMT, Marius Hanl wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Process reviewer comments
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessApplication.java
> l
On Mon, 23 Jun 2025 08:26:30 GMT, Johan Vos wrote:
>> After spending a year in the sandbox repository, the Headless Platform is
>> now ready to be reviewed in the main repository.
>>
>> ### the Headless Platform
>> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
>>
On Thu, 19 Jun 2025 22:18:48 GMT, Michael Strauß wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix missing ;
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessApplication.java
> line 173:
On Thu, 19 Jun 2025 22:36:14 GMT, Michael Strauß wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix missing ;
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessApplication.java
> line 29:
>
On Thu, 19 Jun 2025 22:13:37 GMT, Michael Strauß wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix missing ;
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessRobot.java
> line 277:
>
>>
> After spending a year in the sandbox repository, the Headless Platform is now
> ready to be reviewed in the main repository.
>
> ### the Headless Platform
> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
> the second-level Monocle-Headless subplatform, that is par
> After spending a year in the sandbox repository, the Headless Platform is now
> ready to be reviewed in the main repository.
>
> ### the Headless Platform
> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
> the second-level Monocle-Headless subplatform, that is par
On Thu, 19 Jun 2025 22:49:58 GMT, Michael Strauß wrote:
> My testing shows that the headless platform works as expected.
>
> Some general comments:
>
> 1. All files need a copyright header.
> 2. Very long lines can benefit from a few line breaks.
Thanks for the comments, those make the PR much
On Thu, 19 Jun 2025 08:47:08 GMT, Johan Vos wrote:
>> After spending a year in the sandbox repository, the Headless Platform is
>> now ready to be reviewed in the main repository.
>>
>> ### the Headless Platform
>> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
>>
> After spending a year in the sandbox repository, the Headless Platform is now
> ready to be reviewed in the main repository.
>
> ### the Headless Platform
> The Headless Platform is a top-level com.sun.glass.ui platform that replaces
> the second-level Monocle-Headless subplatform, that is par
After spending a year in the sandbox repository, the Headless Platform is now
ready to be reviewed in the main repository.
### the Headless Platform
The Headless Platform is a top-level com.sun.glass.ui platform that replaces
the second-level Monocle-Headless subplatform, that is part of the top
63 matches
Mail list logo
