On Tue, 20 Feb 2024 12:16:12 GMT, Jose Pereda wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
>> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
>> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
>> 3.8+),
On Sat, 24 Feb 2024 17:34:54 GMT, Thiago Milczarek Sayao
wrote:
>> I've just reverted the previous changes, and just applied the touch mask to
>> the `gdk_pointer_grab` function. Tests should be green now.
>
> @jperedadnr Would you confirm that scroll on a touch screen still works on
> Xorg ?
On Tue, 20 Feb 2024 12:13:31 GMT, Jose Pereda wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add compile-time checks to GdkSeat
>
> I've just reverted the previous changes, and just applied the touch mask to
> the
On Mon, 19 Feb 2024 11:45:04 GMT, Thiago Milczarek Sayao
wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add compile-time checks to GdkSeat
>
> The rationale was:
>
> This tells which events get delivered to the w
On Tue, 20 Feb 2024 12:16:12 GMT, Jose Pereda wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
>> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
>> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
>> 3.8+),
On Tue, 20 Feb 2024 12:16:12 GMT, Jose Pereda wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
>> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
>> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
>> 3.8+),
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
>> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
>> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
>> 3.8+),
> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
> 3.8+), and fixes the dragging issue on Wayland.
Jose Pereda has u
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
>> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
>> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
>> 3.8+),
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
>> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
>> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
>> 3.8+),
On Mon, 19 Feb 2024 00:35:48 GMT, Thiago Milczarek Sayao
wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add compile-time checks to GdkSeat
>
> A shot in the dark since I don't own a touch enabled monitor:
>
> Tes
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
>> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
>> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
>> 3.8+),
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
>> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
>> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
>> 3.8+),
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
>> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
>> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
>> 3.8+),
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
>> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
>> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
>> 3.8+),
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
>> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
>> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
>> 3.8+),
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
>> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
>> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
>> 3.8+),
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
>> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
>> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
>> 3.8+),
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
>> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
>> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
>> 3.8+),
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
>> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
>> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
>> 3.8+),
On Mon, 18 Dec 2023 22:00:28 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add compile-time checks to GdkSeat
>
> The addition of the compile-time flags looks OK.
>
> I did a build with GTK 3
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
>> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
>> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
>> 3.8+),
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
>> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
>> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
>> 3.8+),
On Mon, 18 Dec 2023 22:00:28 GMT, Kevin Rushforth wrote:
> I did a build with GTK 3.22 (so it compiles the new code, does the dlsym, and
> does the runtime check) and verified that there are no regressions when
> running on an older system (Ubuntu 16.04).
That sounds good.
> If we decide that
On Mon, 18 Dec 2023 10:36:32 GMT, Jose Pereda wrote:
>> That's only if we want to keep building working on 16.04. I think it makes
>> easier to test on it.
>> But, it's already failing for Platform preferences API code.
>
> In any case, if `GdkSeat` is available only since 3.20, then we need to
> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
> 3.8+), and fixes the dragging issue on Wayland.
Jose Pereda has u
On Mon, 18 Dec 2023 21:56:09 GMT, Thiago Milczarek Sayao
wrote:
>> As an FYI, we use GTK 3.22 on our CI build machines so I wouldn't want to
>> see the build-time dependency move any higher than it currently is.
>
> The suggestion was to allow building on 16.04 - so it's easier to test. But
>
On Mon, 18 Dec 2023 21:47:05 GMT, Kevin Rushforth wrote:
>> In any case, if `GdkSeat` is available only since 3.20, then we need to add
>> the compile-time checks anyway, since minimum supported is 3.8.
>
> It seems like this is the best we can do for now. What is means is that we
> won't be ab
On Mon, 18 Dec 2023 21:51:13 GMT, Kevin Rushforth wrote:
>> It seems like this is the best we can do for now. What is means is that we
>> won't be able to build on a system with 3.8 - 3.19 and distribute a library
>> that will use the new functionality when running on 3.20 or later. That's
>>
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
>> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
>> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
>> 3.8+),
On Mon, 18 Dec 2023 10:29:00 GMT, Thiago Milczarek Sayao
wrote:
>> Okay, that is unfortunate (GTK docs inaccurate), but makes sense.
>>
>> I'll add the compile-time checks to `wrapped.c`. But then, using `dlsym`
>> seems redundant, as we can simply call the seat functions directly?
>
> The che
On Mon, 18 Dec 2023 10:34:02 GMT, Thiago Milczarek Sayao
wrote:
>> The check is to allow compilation and test on Ubuntu 16.04 - When shipping
>> the final build it should be built on gtk 3.20+, so both dlsym and the check
>> makes sense.
>>
>> So when running on Ubuntu 16.04:
>> - For testin
On Mon, 18 Dec 2023 10:20:35 GMT, Jose Pereda wrote:
>> I think the docs are wrong, I probably exists since 3.20, so maybe check for
>> `GTK_CHECK_VERSION(3, 20, 0);`.
>>
>>
>> This is the compilation error on Ubuntu 16.04:
>> `/home/tsayao/jose/jfx/modules/javafx.graphics/src/main/native-glas
On Mon, 18 Dec 2023 10:09:29 GMT, Thiago Milczarek Sayao
wrote:
>> I take `GdkSeat` is available since GTK 3.0?
>> https://docs.gtk.org/gdk3/class.Seat.html
>>
>> But don't we have a minimum set on 3.8.0?
>>
>> Would this work?
>>
>> #if GTK_CHECK_VERSION(3, 0, 0)
>> static GdkSeat * (*_gdk_
On Mon, 18 Dec 2023 09:46:23 GMT, Jose Pereda wrote:
>> modules/javafx.graphics/src/main/native-glass/gtk/wrapped.c line 197:
>>
>>> 195: return TRUE;
>>> 196: }
>>> 197: return FALSE;
>>
>> I did try to test on Ubuntu 16.04 and compilation failed (no surprise
>> because `GdkSe
On Mon, 18 Dec 2023 09:46:23 GMT, Jose Pereda wrote:
>> modules/javafx.graphics/src/main/native-glass/gtk/wrapped.c line 197:
>>
>>> 195: return TRUE;
>>> 196: }
>>> 197: return FALSE;
>>
>> I did try to test on Ubuntu 16.04 and compilation failed (no surprise
>> because `GdkSe
On Sat, 16 Dec 2023 22:21:55 GMT, Thiago Milczarek Sayao
wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove compile-time if checks
>
> modules/javafx.graphics/src/main/native-glass/gtk/wrapped.c line 197:
>
>>
On Thu, 14 Dec 2023 20:19:12 GMT, Jose Pereda wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
>> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
>> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
>> 3.8+),
On Thu, 14 Dec 2023 20:13:36 GMT, Jose Pereda wrote:
>> modules/javafx.graphics/src/main/native-glass/gtk/glass_general.cpp line 599:
>>
>>> 597: return TRUE;
>>> 598: }
>>> 599: #if GTK_CHECK_VERSION(3, 20, 0)
>>
>> I wouldn't have expected any compile-time `#if` checks as part of
On Thu, 14 Dec 2023 20:19:12 GMT, Jose Pereda wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
>> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
>> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
>> 3.8+),
> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
> 3.8+), and fixes the dragging issue on Wayland.
Jose Pereda has u
On Thu, 14 Dec 2023 16:02:48 GMT, Kevin Rushforth wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
>> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
>> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
>> 3.8
On Tue, 12 Dec 2023 11:19:23 GMT, Jose Pereda wrote:
> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and
> wrapped functions for GTK 3.20+ (so systems without it still run with GTK
> 3.8+), and
This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
`gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and wrapped
functions for GTK 3.20+ (so systems without it still run with GTK 3.8+), and
fixes the dragging issue on Wayland.
-
Commit mes
44 matches
Mail list logo
