On Mon, 18 Dec 2023 21:47:05 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> In any case, if `GdkSeat` is available only since 3.20, then we need to add 
>> the compile-time checks anyway, since minimum supported is 3.8.
>
> It seems like this is the best we can do for now. What is means is that we 
> won't be able to build on a system with 3.8 - 3.19 and distribute a library 
> that will use the new functionality when running on 3.20 or later. That's 
> probably OK in this case, but is worth noting.
> 
> What is important, and why the runtime check is needed (as noted above) is 
> that we can build a production release of JavaFX on a system that has a later 
> GTK and it will run on a system with an older GTK. It won't use the feature 
> on those older systems, but won't crash.

As an FYI, we use GTK 3.22 on our CI build machines so I wouldn't want to see 
the build-time dependency move any higher than it currently is.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1305#discussion_r1430682992

Reply via email to